chore: update deps and adopt shared tooling - #74
Merged
Conversation
jan-kubica
marked this pull request as ready for review
May 31, 2026 18:46
There was a problem hiding this comment.
Code Review
This pull request migrates the project's linting and TypeScript configurations to use shared configurations (@stll/oxlint-config and @stll/typescript-config), replacing the static configuration files with a new oxlint.config.ts and extending the shared TS config in tsconfig.json. It also updates various dependencies in package.json, bun.lock, and Cargo.lock. In src/core.ts, the normalizePatterns function is refactored to accept readonly unknown[] and perform more robust runtime type checks on the input patterns. Feedback suggests adding an explicit Array.isArray check at the beginning of normalizePatterns to prevent runtime iterator errors when called from JavaScript.
jan-kubica
force-pushed
the
chore/deps-shared-tooling
branch
from
May 31, 2026 18:52
e29cd92 to
ad670ed
Compare
jan-kubica
force-pushed
the
chore/deps-shared-tooling
branch
from
May 31, 2026 21:01
ad670ed to
a0ce6a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation