Skip to content

chore: update deps and adopt shared tooling - #74

Merged
jan-kubica merged 2 commits into
mainfrom
chore/deps-shared-tooling
May 31, 2026
Merged

chore: update deps and adopt shared tooling#74
jan-kubica merged 2 commits into
mainfrom
chore/deps-shared-tooling

Conversation

@jan-kubica

Copy link
Copy Markdown
Contributor

Summary

  • update Bun and Rust dependencies
  • adopt @stll TypeScript and oxlint shared tooling
  • fix strict typing/lint findings surfaced by the shared config

Validation

  • bun run lint
  • bun run typecheck
  • bun test test/index.spec.ts
  • bun run test:props
  • bun run build:js
  • cargo check
  • bun pm untrusted

@jan-kubica
jan-kubica marked this pull request as ready for review May 31, 2026 18:46

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the project's linting and TypeScript configurations to use shared configurations (@stll/oxlint-config and @stll/typescript-config), replacing the static configuration files with a new oxlint.config.ts and extending the shared TS config in tsconfig.json. It also updates various dependencies in package.json, bun.lock, and Cargo.lock. In src/core.ts, the normalizePatterns function is refactored to accept readonly unknown[] and perform more robust runtime type checks on the input patterns. Feedback suggests adding an explicit Array.isArray check at the beginning of normalizePatterns to prevent runtime iterator errors when called from JavaScript.

Comment thread src/core.ts
@jan-kubica
jan-kubica force-pushed the chore/deps-shared-tooling branch from e29cd92 to ad670ed Compare May 31, 2026 18:52
@jan-kubica
jan-kubica force-pushed the chore/deps-shared-tooling branch from ad670ed to a0ce6a3 Compare May 31, 2026 21:01
@jan-kubica
jan-kubica merged commit 9575b62 into main May 31, 2026
20 checks passed
@jan-kubica
jan-kubica deleted the chore/deps-shared-tooling branch May 31, 2026 22:16
@github-actions github-actions Bot locked and limited conversation to collaborators May 31, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant