[codex] Add saved browser conversation follow-up API#231
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed May 30, 2026, 1:37 AM ET / 05:37 UTC. Summary Reproducibility: not applicable. as a feature PR. Source review confirms current main has API follow-up and planned in-run browser follow-ups, but not this saved browser conversation child-session API. Review metrics: 3 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Land the saved-browser follow-up API only after preserving existing MCP consult compatibility, shipping or scoping the helper correctly, wiring browser parent lineage into session display, and adding real browser proof. Do we have a high-confidence way to reproduce the issue? Not applicable as a feature PR. Source review confirms current main has API follow-up and planned in-run browser follow-ups, but not this saved browser conversation child-session API. Is this the best way to solve the issue? No. The direction is useful, but the current patch is not the best merge shape until the MCP compatibility change is narrowed or explicitly approved, helper distribution is fixed, and browser lineage/proof are added. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against 6019a199e44c. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Summary
Adds a public follow-up API for continuing an existing saved ChatGPT browser conversation without mutating the parent Oracle session.
oracle follow-up <parentSessionId> [prompt]with--prompt,--slug,--wait/--no-wait, and--no-recover.follow_upreturningsessionId,parentSessionId,status, andlogTail.parentSessionId/followUpOfSessionId, copying parent browser config while forcing follow-up runs out of Deep Research mode.Recovery fixes
This also hardens the long-browser-run recovery path:
oracle-awaitrender-poll helper for stalestatus:"running"sessions.status:"error"plus an existing non-emptyartifacts/transcript.mdas a completed captured result, covering wrapper cleanup crashes such as Node/undicisetTypeOfService EINVALafter the answer was already saved.Validation
pnpm exec vitest run tests/cli/sessionFinalizer.test.ts tests/cli/browserFollowUp.test.ts tests/mcp/followUp.test.ts tests/cli/promptRequirement.test.ts tests/cli/sessionCommand.test.ts tests/mcp/sessions.test.ts tests/mcp/consult.test.ts tests/browser/recoverConversation.test.ts tests/browser/sessionRunner.test.ts tests/browser/index.test.ts tests/cli/integrationCli.test.tspnpm run typecheckpnpm run buildoracle-awaitreturnsREADYforstatus:errorwhenartifacts/transcript.mdis presentNotes
Upstream already has
--browser-follow-upfor planned extra turns inside a fresh browser consult and API--followupfor Responses API chaining. This PR covers a different path: sending a new prompt to an already saved/recoverable ChatGPT browser conversation as a separate child session.