Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling multiple layers #7

Merged
merged 12 commits into from
Apr 8, 2015
Merged

Conversation

Wilkins
Copy link
Collaborator

@Wilkins Wilkins commented Apr 4, 2015

Hi Stefano,

I added some new stuff :

  • a layer switcher
  • a new javascript object LayerOptimizer to handle all the layers manipulations (optimize, display etc)
  • handling CSS with SASS (I hope you won't mind)
  • ordering JS files in js/ folder

You can test this version here : http://wilkins.fr/layers/

Thank you for adding me in the contributors list, I really appreciated it !

Hope you'll like it.
Have a nice day.

@stefanocudini
Copy link
Owner

Hi @Wilkins!

SASS is ok, as long you use Grunt plugins to build the dist files all is well!

Only one thing.. when i work in required projects i prefer /src/ instead js dir contains js and other required files.. and /lib/ instead /vendor/

stefanocudini added a commit that referenced this pull request Apr 8, 2015
Handling multiple layers
@stefanocudini stefanocudini merged commit 29e2536 into stefanocudini:master Apr 8, 2015
@Wilkins
Copy link
Collaborator Author

Wilkins commented Apr 8, 2015

Hi @stefanocudini
Of course Sass goes with grunt, they are best friends :-)
Ok no problem.
I have other pull requests to come, so I'll rename :

  • js -> src
  • vendor -> lib

Have a nice day.

@Wilkins Wilkins deleted the layers branch April 8, 2015 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants