use rng also for pop!

stecrotti · Mar 4, 2024 · 36b494c · 36b494c · stecrotti · Mar 4, 2024
1 parent 432eb88
commit 36b494c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "MatrixProductBP"
 uuid = "3d39929c-b583-45fa-b331-3f50b693a38a"
 authors = ["stecrotti <[email protected]>"]
-version = "0.2.0"
+version = "0.3.0"
 
 [deps]
 CavityTools = "217fe2f1-7e3d-419f-9934-cd6900c2759a"
@@ -28,7 +28,7 @@ UnPack = "3a884ed6-31ef-47d7-9d2a-63182c4928ed"
 Unzip = "41fe7b60-77ed-43a1-b4f0-825fd5a5650d"
 
 [compat]
-CavityTools = "0.2.1"
+CavityTools = "0.3 - 1"
 Distributions = "0.25"
 IndexedGraphs = "0.3, 0.4"
 InvertedIndices = "1"

diff --git a/src/sampling.jl b/src/sampling.jl
@@ -225,7 +225,7 @@ function simulate_queue_sis!(x, g, P0, λ, μ, T;
         end
     end
     while !isempty(Q)
-        i, Δt = pop!(Q)
+        i, Δt = pop!(Q; rng)
         t += Δt
         t > T && break
         x[i] ⊻= true

diff --git a/test/sampling.jl b/test/sampling.jl
@@ -32,10 +32,11 @@
         @test all(all(all(-1 ≤ x.val ≤ 1 for x in cit) for cit in ci) for ci in c)
     end
 
-    # just check that it runs without errors
-    @testset "sampling - Gillespie" begin
+    @testset "sampling - Gillespie - reproducibility" begin
         av, va = continuous_sis_sampler(sis, T, λ, ρ; nsamples = 10^4, sites=1,
-        discard_dead_epidemics=true)
-        @test true
+        discard_dead_epidemics=true, rng = MersenneTwister(0))
+        av2, va2 = continuous_sis_sampler(sis, T, λ, ρ; nsamples = 10^4, sites=1,
+        discard_dead_epidemics=true, rng = MersenneTwister(0))
+        @test av2 == av && va2 == va  
     end
 end