Repository navigation
Send Helo mail through stechstudio/laravel-helo-email - #35
Merged
Merged
Conversation
With persistence off, nothing removed Postmaster's X-Postmaster-* headers before sending, so every provider received them. With it on, only the headers the stash listener knows were removed. A final listener now strips all of them after Postmaster has read them.
Postmaster's own Helo client and transport move into a standalone package. Postmaster keeps webhooks, sync, and the dashboard. - Send through the package's helo transport and read its send result - Sync and unsuppress through the package's API client - Read the API key, channel, and mail type from config/helo.php - Name the package in the Helo setup wizard and setup report
Drop the local path repository used during development.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Postmaster's built-in Helo client and transport move into a standalone package, stechstudio/laravel-helo-email. Postmaster keeps webhooks, suppression sync, and the dashboard.
What changes
helomail transport. Postmaster reads the send result throughHeloResult::from()to record suppressed recipients asdroppedand delayed sends asdeferred, as before.config/helo.php(HELO_API_KEY,HELO_CHANNEL_ID,HELO_MAIL_TYPE).postmaster.providers.helokeepssigning_keyand the webhook settings.X-Postmaster-*headers no longer reach the provider when persistence is off. A finalMessageSendinglistener strips any left after Postmaster has read them, in both modes.Breaking
POSTMASTER_HELO_API_KEY,POSTMASTER_HELO_CHANNEL_ID, andPOSTMASTER_HELO_MAIL_TYPEare gone; use theHELO_*names. API sending and Helo sync now needcomposer require stechstudio/laravel-helo-email. Helo support hasn't shipped in a release yet, so no released app is affected.Testing
HeloIntegrationTestcovers sending through the package end to end: correlation, partial suppressions, delayed submission, resend, and sandbox release.