feat: add lapack/base/dlapy2
#2845
Conversation
Pranavchiku
added
Feature
| if ( isnan( x ) || isnan( y ) ) { | ||
| return NaN; | ||
| } | ||
| hugeval = dlamch( 'O' ); |
There was a problem hiding this comment.
@Pranavchiku Isn't this a value a constant and can be elevated to the parent scope? I don't believe we need to call dlamch for each invocation.
| ```javascript | ||
| var randu = require( '@stdlib/random/base/randu' ); | ||
| var round = require( '@stdlib/math/base/special/round' ); | ||
|
|
There was a problem hiding this comment.
@Pranavchiku You are missing a require statement here.
| * var v = dlapy2( -5.0, 12.0 ); | ||
| * // returns 13.0 | ||
| */ | ||
| function dlapy2( x, y ) { |
There was a problem hiding this comment.
This implementation is effectively hypot. As such, I'd just have dlapy2 wrap that function. No need to reinvent the wheel.
| if ( z === 0.0 || w > hugeval ) { | ||
| return w; | ||
| } | ||
| return w * sqrt( 1.0 + pow( ( z / w ), 2 ) ); |
There was a problem hiding this comment.
No need to use pow BTW. You can use abs2 which is much lighter weight.
kgryte
added
the
Needs Changes
kgryte
added
the
autoclose: Already Resolved
|
Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit. Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions. |
Towards #2464.
Description
This pull request adds JS implementation for
lapack/base/dlapy2.Related Issues
NA
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers