feat: add lapack/base/dlapy2
#2845
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pranavchiku
added
Feature
kgryte
reviewed
Sep 17, 2024
| if ( isnan( x ) || isnan( y ) ) { | ||
| return NaN; | ||
| } | ||
| hugeval = dlamch( 'O' ); |
There was a problem hiding this comment.
@Pranavchiku Isn't this a value a constant and can be elevated to the parent scope? I don't believe we need to call dlamch for each invocation.
kgryte
reviewed
Sep 17, 2024
| ```javascript | ||
| var randu = require( '@stdlib/random/base/randu' ); | ||
| var round = require( '@stdlib/math/base/special/round' ); | ||
|
|
There was a problem hiding this comment.
@Pranavchiku You are missing a require statement here.
kgryte
reviewed
Sep 17, 2024
| * var v = dlapy2( -5.0, 12.0 ); | ||
| * // returns 13.0 | ||
| */ | ||
| function dlapy2( x, y ) { |
There was a problem hiding this comment.
This implementation is effectively hypot. As such, I'd just have dlapy2 wrap that function. No need to reinvent the wheel.
kgryte
reviewed
Sep 17, 2024
| if ( z === 0.0 || w > hugeval ) { | ||
| return w; | ||
| } | ||
| return w * sqrt( 1.0 + pow( ( z / w ), 2 ) ); |
There was a problem hiding this comment.
No need to use pow BTW. You can use abs2 which is much lighter weight.
kgryte
added
the
Needs Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2464.
Description
This pull request adds JS implementation for
lapack/base/dlapy2.Related Issues
NA
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers