Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sort Name to Tags #5531

Merged
merged 12 commits into from
Feb 10, 2025
Merged

Add Sort Name to Tags #5531

merged 12 commits into from
Feb 10, 2025

Conversation

stg-annon
Copy link
Collaborator

@stg-annon stg-annon commented Dec 4, 2024

adds a sort name to tags
Resolves #3108

this could go nowhere, testing things out
override "name" sort with COALESCE
adds `data-sort-name` attribute to tag links prioritizes sort_name value but will default to tag name if not present in the same way that COALESCE will prioritize the same values in the same way
@DogmaDragon
Copy link
Collaborator

Lightly tested, no more issues found.

@WithoutPants WithoutPants added this to the Version 0.28.0 milestone Feb 7, 2025
@WithoutPants WithoutPants added the feature Pull requests that add a new feature label Feb 7, 2025
Copy link
Collaborator

@WithoutPants WithoutPants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good. I made the following changes:

  • Changed the display name to be Sort Name instead of Sorting Name
  • Added new field to anonymiser
  • Added new field to import/export

@WithoutPants WithoutPants merged commit d2daf6c into stashapp:develop Feb 10, 2025
2 checks passed
@stg-annon stg-annon deleted the tag_sort_name branch February 11, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull requests that add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Sort_Name for Tags
3 participants