small cleanup

stashapp · Feb 11, 2025 · e4c4ce8 · e4c4ce8
1 parent 0dad539
commit e4c4ce8
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/ui/v2.5/src/components/ScenePlayer/ScenePlayer.tsx b/ui/v2.5/src/components/ScenePlayer/ScenePlayer.tsx
@@ -701,14 +701,15 @@ export const ScenePlayer: React.FC<IScenePlayerProps> = ({
     // Ensure markers are added after player is fully ready and sources are loaded
     if (player.readyState() >= 1) {
       loadMarkers();
+      return;
     } else {
       player.on("loadedmetadata", () => {
         loadMarkers();
       });
+      return () => {
+        player.off("loadedmetadata", loadMarkers);
+      };
     }
-    return () => {
-      player.off("loadedmetadata", loadMarkers);
-    };
   }, [getPlayer, scene]);
 
   useEffect(() => {