test(blockifier): test secp_get_point_from_x #6366
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Artifacts upload workflows: |
aner-starkware
changed the title
aner-starkware
requested review from
ilyalesokhin-starkware and
dorimedini-starkware
dorimedini-starkware
requested changes
May 7, 2025
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)
crates/blockifier_test_utils/resources/feature_contracts/cairo1/test_contract.cairo line 401 at r1 (raw file):
assert(x_coord == x && y_coord == expected_y, 'Unexpected coordinates'); let (x_coord, y_coord) = starknet::secp256k1::secp256k1_get_xy_syscall(p1).unwrap_syscall(); assert(x_coord == x && y_coord != expected_y, 'Unexpected coordinates');
why not define an expected_p1_y value?
Code quote:
y_coord != expected_y
aner-starkware
force-pushed
the
aner/snos_secp_syscalls
branch
from
9a509b6 to
fdf37da
Compare
aner-starkware
force-pushed
the
aner/test_new_point_x_coordinate
branch
from
f59dde3 to
af88988
Compare
aner-starkware
force-pushed
the
aner/test_new_point_x_coordinate
branch
from
af88988 to
9f9a210
Compare
|
Previously, dorimedini-starkware wrote…
Done. |
dorimedini-starkware
approved these changes
May 7, 2025
There was a problem hiding this comment.
Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.