fix(ci): update committer benchmark comment #6360
Conversation
|
This change is |
|
fs.readFileSync('bench_new.txt', 'utf8'), |
aner-starkware
force-pushed
the
aner/fix_committer_comment
branch
3 times, most recently
from
fa38c6d to
c7d304c
Compare
|
$(fs.readFileSync('bench_new.txt', 'utf8')), |
aner-starkware
force-pushed
the
aner/fix_committer_comment
branch
from
c7d304c to
79929fa
Compare
|
Benchmark movements: No major performance changes detected. |
aner-starkware
force-pushed
the
aner/fix_committer_comment
branch
8 times, most recently
from
88e6e52 to
15c63ad
Compare
aner-starkware
force-pushed
the
aner/fix_committer_comment
branch
2 times, most recently
from
20bdc79 to
efacce8
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware)
a discussion (no related file):
this looks like a bug, can you open another PR above this one to test this?
Previously, dorimedini-starkware wrote…
It is not a bug; it was a bug that's already fixed (this text no longer appears in the PR). |
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @nimrod-starkware)
a discussion (no related file):
Previously, aner-starkware wrote…
It is not a bug; it was a bug that's already fixed (this text no longer appears in the PR).
ok, but I don't see the committer report, only the No major performance changes detected message.
can you open a dummy PR above this one that just triggers the committer benchmark?
trigger it, see what the first message is, amend the commit without no changes, push again to re-trigger, and make sure all is well
Previously, dorimedini-starkware wrote…
I already saw the committer report - it looks almost the same, except now there are no newlines (the format changed). How do I "trigger" the committer report? I can just push again in the commit, but unless there are any changes, it will print this message. |
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @nimrod-starkware)
a discussion (no related file):
Previously, aner-starkware wrote…
I already saw the committer report - it looks almost the same, except now there are no newlines (the format changed). How do I "trigger" the committer report? I can just push again in the commit, but unless there are any changes, it will print this message.
that's why you need a new dummy PR above this one, not a new commit
Previously, dorimedini-starkware wrote…
What's the difference? I don't follow. I can do it without a new commit even, it will still trigger the benchmarking and update the comment. Only problem is that the updated comment could possibly be equivalent to the existing one... Previously there was a comment with modifications, but it was already overwritten. |
aner-starkware
force-pushed
the
aner/fix_committer_comment
branch
from
efacce8 to
f37aad3
Compare
There was a problem hiding this comment.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @aner-starkware and @nimrod-starkware)
a discussion (no related file):
Previously, aner-starkware wrote…
What's the difference? I don't follow. I can do it without a new commit even, it will still trigger the benchmarking and update the comment. Only problem is that the updated comment could possibly be equivalent to the existing one... Previously there was a comment with modifications, but it was already overwritten.
if your feature works, then pushing new commits to this PR won't every create a new comment, because there is an existing one.
I want to test the effect on a proper benchmarking comment, hence, new PR
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @nimrod-starkware)
aner-starkware
changed the title
Previously, dorimedini-starkware wrote…
עדיין לא הצלחתי להבין מה בדיוק אתה רוצה לראות, אבל הנה |
Previously, aner-starkware wrote…
אגב, למרות שהוספתי שם הדפסות, לא נראה שינוי (ופה דווקא כן - אולי יש הטייה לטובה לשינוי...) |
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)
a discussion (no related file):
Previously, aner-starkware wrote…
אגב, למרות שהוספתי שם הדפסות, לא נראה שינוי (ופה דווקא כן - אולי יש הטייה לטובה לשינוי...)
hmmm... ok so your feature replaces previous text with new text each time, right?
now i understand why this conversation was a broken phone lol
No description provided.