Skip to content

chore(apollo_deployments): remove override references #6355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025
+31 −31
Merged

chore(apollo_deployments): remove override references #6355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions crates/apollo_deployments/src/deployment.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,26 +175,26 @@ impl Deployment {

#[derive(Debug, Serialize)]
pub struct ConfigOverride {
deployment_config_override: &'static DeploymentConfigOverride,
instance_config_override: &'static InstanceConfigOverride,
deployment_config_override: DeploymentConfigOverride,
instance_config_override: InstanceConfigOverride,
}

impl ConfigOverride {
pub const fn new(
deployment_config_override: &'static DeploymentConfigOverride,
instance_config_override: &'static InstanceConfigOverride,
deployment_config_override: DeploymentConfigOverride,
instance_config_override: InstanceConfigOverride,
) -> Self {
Self { deployment_config_override, instance_config_override }
}

pub fn create(&self, application_config_subdir: &Path) -> Vec<String> {
serialize_to_file(
to_value(self.deployment_config_override).unwrap(),
to_value(&self.deployment_config_override).unwrap(),
application_config_subdir.join(DEPLOYMENT_FILE_NAME).to_str().unwrap(),
);

serialize_to_file(
to_value(self.instance_config_override).unwrap(),
to_value(&self.instance_config_override).unwrap(),
application_config_subdir.join(INSTANCE_FILE_NAME).to_str().unwrap(),
);
vec![DEPLOYMENT_FILE_NAME.to_string(), INSTANCE_FILE_NAME.to_string()]
Expand Down
16 changes: 8 additions & 8 deletions crates/apollo_deployments/src/deployment_definitions/sepolia_integration.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,20 +71,20 @@ const SEPOLIA_INTEGRATION_NODE_3_INSTANCE_CONFIG_OVERRIDE: InstanceConfigOverrid
);

const SEPOLIA_INTEGRATION_NODE_0_CONFIG_OVERRIDE: ConfigOverride = ConfigOverride::new(
&SEPOLIA_INTEGRATION_DEPLOYMENT_CONFIG_OVERRIDE,
&SEPOLIA_INTEGRATION_NODE_0_INSTANCE_CONFIG_OVERRIDE,
SEPOLIA_INTEGRATION_DEPLOYMENT_CONFIG_OVERRIDE,
SEPOLIA_INTEGRATION_NODE_0_INSTANCE_CONFIG_OVERRIDE,
);
const SEPOLIA_INTEGRATION_NODE_1_CONFIG_OVERRIDE: ConfigOverride = ConfigOverride::new(
&SEPOLIA_INTEGRATION_DEPLOYMENT_CONFIG_OVERRIDE,
&SEPOLIA_INTEGRATION_NODE_1_INSTANCE_CONFIG_OVERRIDE,
SEPOLIA_INTEGRATION_DEPLOYMENT_CONFIG_OVERRIDE,
SEPOLIA_INTEGRATION_NODE_1_INSTANCE_CONFIG_OVERRIDE,
);
const SEPOLIA_INTEGRATION_NODE_2_CONFIG_OVERRIDE: ConfigOverride = ConfigOverride::new(
&SEPOLIA_INTEGRATION_DEPLOYMENT_CONFIG_OVERRIDE,
&SEPOLIA_INTEGRATION_NODE_2_INSTANCE_CONFIG_OVERRIDE,
SEPOLIA_INTEGRATION_DEPLOYMENT_CONFIG_OVERRIDE,
SEPOLIA_INTEGRATION_NODE_2_INSTANCE_CONFIG_OVERRIDE,
);
const SEPOLIA_INTEGRATION_NODE_3_CONFIG_OVERRIDE: ConfigOverride = ConfigOverride::new(
&SEPOLIA_INTEGRATION_DEPLOYMENT_CONFIG_OVERRIDE,
&SEPOLIA_INTEGRATION_NODE_3_INSTANCE_CONFIG_OVERRIDE,
SEPOLIA_INTEGRATION_DEPLOYMENT_CONFIG_OVERRIDE,
SEPOLIA_INTEGRATION_NODE_3_INSTANCE_CONFIG_OVERRIDE,
);

const SEPOLIA_INTEGRATION_HTTP_SERVER_INGRESS_ALTERNATIVE_NAME: &str =
Expand Down
2 changes: 1 addition & 1 deletion crates/apollo_deployments/src/deployment_definitions/testing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const TESTING_INSTANCE_CONFIG_OVERRIDE: InstanceConfigOverride = InstanceConfigO
);

const TESTING_CONFIG_OVERRIDE: ConfigOverride =
ConfigOverride::new(&TESTING_DEPLOYMENT_CONFIG_OVERRIDE, &TESTING_INSTANCE_CONFIG_OVERRIDE);
ConfigOverride::new(TESTING_DEPLOYMENT_CONFIG_OVERRIDE, TESTING_INSTANCE_CONFIG_OVERRIDE);

const TESTING_INGRESS_DOMAIN: &str = "sw-dev.io";

Expand Down
16 changes: 8 additions & 8 deletions crates/apollo_deployments/src/deployment_definitions/testing_env_2.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,20 +71,20 @@ const TESTING_ENV_2_NODE_3_INSTANCE_CONFIG_OVERRIDE: InstanceConfigOverride =
);

const TESTING_ENV_2_NODE_0_CONFIG_OVERRIDE: ConfigOverride = ConfigOverride::new(
&TESTING_ENV_2_DEPLOYMENT_CONFIG_OVERRIDE,
&TESTING_ENV_2_NODE_0_INSTANCE_CONFIG_OVERRIDE,
TESTING_ENV_2_DEPLOYMENT_CONFIG_OVERRIDE,
TESTING_ENV_2_NODE_0_INSTANCE_CONFIG_OVERRIDE,
);
const TESTING_ENV_2_NODE_1_CONFIG_OVERRIDE: ConfigOverride = ConfigOverride::new(
&TESTING_ENV_2_DEPLOYMENT_CONFIG_OVERRIDE,
&TESTING_ENV_2_NODE_1_INSTANCE_CONFIG_OVERRIDE,
TESTING_ENV_2_DEPLOYMENT_CONFIG_OVERRIDE,
TESTING_ENV_2_NODE_1_INSTANCE_CONFIG_OVERRIDE,
);
const TESTING_ENV_2_NODE_2_CONFIG_OVERRIDE: ConfigOverride = ConfigOverride::new(
&TESTING_ENV_2_DEPLOYMENT_CONFIG_OVERRIDE,
&TESTING_ENV_2_NODE_2_INSTANCE_CONFIG_OVERRIDE,
TESTING_ENV_2_DEPLOYMENT_CONFIG_OVERRIDE,
TESTING_ENV_2_NODE_2_INSTANCE_CONFIG_OVERRIDE,
);
const TESTING_ENV_2_NODE_3_CONFIG_OVERRIDE: ConfigOverride = ConfigOverride::new(
&TESTING_ENV_2_DEPLOYMENT_CONFIG_OVERRIDE,
&TESTING_ENV_2_NODE_3_INSTANCE_CONFIG_OVERRIDE,
TESTING_ENV_2_DEPLOYMENT_CONFIG_OVERRIDE,
TESTING_ENV_2_NODE_3_INSTANCE_CONFIG_OVERRIDE,
);

const TESTING_ENV_2_HTTP_SERVER_INGRESS_ALTERNATIVE_NAME: &str =
Expand Down
16 changes: 8 additions & 8 deletions crates/apollo_deployments/src/deployment_definitions/testing_env_3.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,20 +71,20 @@ const TESTING_ENV_3_NODE_3_INSTANCE_CONFIG_OVERRIDE: InstanceConfigOverride =
);

const TESTING_ENV_3_NODE_0_CONFIG_OVERRIDE: ConfigOverride = ConfigOverride::new(
&TESTING_ENV_3_DEPLOYMENT_CONFIG_OVERRIDE,
&TESTING_ENV_3_NODE_0_INSTANCE_CONFIG_OVERRIDE,
TESTING_ENV_3_DEPLOYMENT_CONFIG_OVERRIDE,
TESTING_ENV_3_NODE_0_INSTANCE_CONFIG_OVERRIDE,
);
const TESTING_ENV_3_NODE_1_CONFIG_OVERRIDE: ConfigOverride = ConfigOverride::new(
&TESTING_ENV_3_DEPLOYMENT_CONFIG_OVERRIDE,
&TESTING_ENV_3_NODE_1_INSTANCE_CONFIG_OVERRIDE,
TESTING_ENV_3_DEPLOYMENT_CONFIG_OVERRIDE,
TESTING_ENV_3_NODE_1_INSTANCE_CONFIG_OVERRIDE,
);
const TESTING_ENV_3_NODE_2_CONFIG_OVERRIDE: ConfigOverride = ConfigOverride::new(
&TESTING_ENV_3_DEPLOYMENT_CONFIG_OVERRIDE,
&TESTING_ENV_3_NODE_2_INSTANCE_CONFIG_OVERRIDE,
TESTING_ENV_3_DEPLOYMENT_CONFIG_OVERRIDE,
TESTING_ENV_3_NODE_2_INSTANCE_CONFIG_OVERRIDE,
);
const TESTING_ENV_3_NODE_3_CONFIG_OVERRIDE: ConfigOverride = ConfigOverride::new(
&TESTING_ENV_3_DEPLOYMENT_CONFIG_OVERRIDE,
&TESTING_ENV_3_NODE_3_INSTANCE_CONFIG_OVERRIDE,
TESTING_ENV_3_DEPLOYMENT_CONFIG_OVERRIDE,
TESTING_ENV_3_NODE_3_INSTANCE_CONFIG_OVERRIDE,
);

const TESTING_ENV_3_HTTP_SERVER_INGRESS_ALTERNATIVE_NAME: &str =
Expand Down