Represent match arm wrapper as an enum with explicit cases

[eytan-starkware]

Stack:

• Common reporting code in lower_match #7727
• Represent match arm wrapper as an enum with explicit cases #7726 ⬅
• Code Cleanup in lowering matching code #7715
• Match on enum arm collection using tree structure #7713

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

[reviewable-StarkWare]

This change is 

[orizi]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @TomerStarkware)

---

crates/cairo-lang-lowering/src/lower/lower_match.rs line 52 at r1 (raw file):

/// MatchArm wrapper that allows for:
/// regular match patterns, else clause, and default (no else) clauses.

rephrase - the doc above should describe what is the meaning of the enum - description of the variants should be lest at the variants.

Code quote:

/// MatchArm wrapper that allows for:
/// regular match patterns, else clause, and default (no else) clauses.

---

crates/cairo-lang-lowering/src/lower/lower_match.rs line 672 at r1 (raw file):

    let pattern = pattern_path
        .pattern_index
        .map(|i| arms[pattern_path.arm_index].pattern(ctx, i).unwrap().clone());

Suggestion:

    let pattern = pattern_path
        .pattern_index
        .and(|i| arms[pattern_path.arm_index].pattern(ctx, i).cloned());

[eytan-starkware]

Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @orizi and @TomerStarkware)

---

crates/cairo-lang-lowering/src/lower/lower_match.rs line 52 at r1 (raw file):

Previously, orizi wrote…

rephrase - the doc above should describe what is the meaning of the enum - description of the variants should be lest at the variants.

Done.

---

crates/cairo-lang-lowering/src/lower/lower_match.rs line 672 at r1 (raw file):

    let pattern = pattern_path
        .pattern_index
        .map(|i| arms[pattern_path.arm_index].pattern(ctx, i).unwrap().clone());

I tried to preserve a compiler crash if we don't have a pattern when the index is available. That is, we previously found the pattern at this arm, but now it doesn't exist. Do we want to change that case to continue as if pattern is None?

[orizi]

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @eytan-starkware and @TomerStarkware)

---

crates/cairo-lang-lowering/src/lower/lower_match.rs line 672 at r1 (raw file):

Previously, eytan-starkware wrote…

I tried to preserve a compiler crash if we don't have a pattern when the index is available. That is, we previously found the pattern at this arm, but now it doesn't exist. Do we want to change that case to continue as if pattern is None?

rather not have explicit unwraps - if you insist - add an expect.

[orizi]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @eytan-starkware and @TomerStarkware)

[eytan-starkware]

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @orizi and @TomerStarkware)

---

crates/cairo-lang-lowering/src/lower/lower_match.rs line 672 at r1 (raw file):

Previously, orizi wrote…

rather not have explicit unwraps - if you insist - add an expect.

Done.

[orizi]

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)

[TomerStarkware]

Reviewed all commit messages.
Reviewable status: 3 of 4 files reviewed, all discussions resolved (waiting on @orizi)

[orizi]

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @eytan-starkware)

[orizi]

Reviewed 2 of 2 files at r7, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @eytan-starkware)