Enable function specialization.

[ilyalesokhin-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[ilyalesokhin-starkware]

• Enable function specialization. #7720 👈 (View in Graphite)
• Add SpecializedFunction. #7718
• Avoid using ConcreteFunctionWithBodyLongId.function_with_body_id. #7753
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[orizi]

Reviewed 3 of 50 files at r2, all commit messages.
Reviewable status: 3 of 50 files reviewed, 2 unresolved discussions

---

crates/cairo-lang-lowering/src/db.rs line 316 at r2 (raw file):

    fn priv_should_inline(&self, function_id: ids::ConcreteFunctionWithBodyId) -> Maybe<bool>;

    // Internal query for a heuristic to decide if a given `function_id` should be specalized.

Suggestion:

    /// Returns whether a function should be specalized.

---

crates/cairo-lang-lowering/src/db.rs line 846 at r2 (raw file):

        panic!("Expected a specialized function");
    };
    // The size is 8/10*orig_size > specialized_size of the original size.

Suggestion:

    // The heuristic is that the size is 8/10*orig_size > specialized_size of the original size.

[ilyalesokhin-starkware]

Reviewable status: 2 of 50 files reviewed, 2 unresolved discussions (waiting on @orizi)

---

crates/cairo-lang-lowering/src/db.rs line 316 at r2 (raw file):

    fn priv_should_inline(&self, function_id: ids::ConcreteFunctionWithBodyId) -> Maybe<bool>;

    // Internal query for a heuristic to decide if a given `function_id` should be specalized.

Done.

---

crates/cairo-lang-lowering/src/db.rs line 846 at r2 (raw file):

        panic!("Expected a specialized function");
    };
    // The size is 8/10*orig_size > specialized_size of the original size.

Done.

[orizi]

Reviewed 9 of 50 files at r2, 1 of 1 files at r3.
Reviewable status: 12 of 50 files reviewed, 1 unresolved discussion

---

crates/cairo-lang-lowering/src/optimizations/const_folding.rs line 482 at r3 (raw file):

    }

    fn try_specialize_call(

doc

[orizi]

Reviewed 38 of 50 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @ilyalesokhin-starkware)

[orizi]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-lowering/src/optimizations/const_folding.rs line 485 at r4 (raw file):

    /// Returns None if the call should not be specialized.
    ///
    /// Specialization of the with the same base is currently not supported, and specialization

Suggestion:

/// Specialization of the ?what? with the same base 

[orizi]

Reviewed 5 of 5 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)

[ilyalesokhin-starkware]

Reviewable status: 49 of 50 files reviewed, 1 unresolved discussion (waiting on @orizi)

---

crates/cairo-lang-lowering/src/optimizations/const_folding.rs line 482 at r3 (raw file):

Previously, orizi wrote…

doc

Done.

---

crates/cairo-lang-lowering/src/optimizations/const_folding.rs line 485 at r4 (raw file):

    /// Returns None if the call should not be specialized.
    ///
    /// Specialization of the with the same base is currently not supported, and specialization

Done.

[orizi]

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)