Skip to content

Preventing potential unintended Copy of vars in const-folding. #7701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2025

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Apr 24, 2025

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@orizi orizi requested a review from gilbens-starkware April 24, 2025 10:40
@orizi orizi force-pushed the spr/main/ba1cf1e3 branch from f32d09e to ef23f0d Compare April 29, 2025 07:12
@orizi orizi force-pushed the spr/main/8e3dc5aa branch from 4b66528 to 1e562dd Compare April 29, 2025 07:12
@orizi orizi force-pushed the spr/main/ba1cf1e3 branch from ef23f0d to 60ed25d Compare April 29, 2025 07:39
@orizi orizi force-pushed the spr/main/8e3dc5aa branch from 1e562dd to 4d91c90 Compare April 29, 2025 07:39
@orizi orizi force-pushed the spr/main/ba1cf1e3 branch from 60ed25d to e38d472 Compare May 7, 2025 12:20
@orizi orizi force-pushed the spr/main/8e3dc5aa branch from 4d91c90 to 83d6e6d Compare May 7, 2025 12:20
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi changed the base branch from spr/main/8e3dc5aa to main May 11, 2025 06:13
@orizi orizi force-pushed the spr/main/ba1cf1e3 branch from e38d472 to 3d4c33e Compare May 11, 2025 06:13
@orizi orizi added this pull request to the merge queue May 11, 2025
Merged via the queue into main with commit 8fc2c72 May 11, 2025
96 checks passed
@orizi orizi deleted the spr/main/ba1cf1e3 branch May 13, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants