fix: argument order in cargo clippy command #7593
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
orizi
requested changes
Apr 6, 2025
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions
a discussion (no related file):
this is for our internal usage - so not really relevant.
a discussion (no related file):
fixing of internal scripts for ease of use is done when running into issues.
we no longer accept PRs for such improvements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I noticed that user-provided arguments (
$@) were placed before the standardcargo clippyflags. This could cause conflicts or unexpected behavior if user args overlap with cargo's own flags.I moved
$@to the correct spot—aftercargo clippybut before--all-targets, etc.—so everything gets passed as intended.