Skip to content

Commit

Permalink
pnpm by default doesn't publish when there are git changes, we need t…
Browse files Browse the repository at this point in the history
…o disable that flag for unstable because we don't want to commit those changes
  • Loading branch information
NullVoxPopuli committed Oct 11, 2023
1 parent e2eb8cc commit f679264
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
11 changes: 8 additions & 3 deletions workspace/unstable-release/src/publish.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ async function publish() {
console.info(`Publishing ${workspace}`);
try {
await execaCommand(
"pnpm publish --tag=unstable --verbose --access=public",
"pnpm publish --tag unstable --access public --no-git-checks",
{
cwd: dirname(workspace),
},
Expand All @@ -64,7 +64,9 @@ async function publish() {
);

if (isErr(err)) {
errors.push(err.stderr);
/** @type {any} */
let out = err;
errors.push(`${out.stdout ?? ''} ${err.stderr}`);
erroredPackages.push(name);
}
continue;
Expand All @@ -75,7 +77,10 @@ async function publish() {

if (errors.length) {
console.error("Errors were encountered while publishing these packages");
errors.forEach((error) => void console.log(error));
errors
.map(e => e.trim())
.filter(Boolean)
.forEach((error) => void console.log(error));

console.info(
'------------------------------------------\n'
Expand Down
1 change: 0 additions & 1 deletion workspace/unstable-release/src/workspaces.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import { readPackageJson } from "./read-package-json.js";
export async function listPublicWorkspaces() {
let filePaths = await globby([
"packages/**/package.json",
"workspace/@domtree/**/package.json"
], {
gitignore: true,
ignore: ["**/tests/**", "**/node_modules/**"],
Expand Down

0 comments on commit f679264

Please sign in to comment.