More infra cleanup

The infra updates also revealed lint errors that I corrected.
starbeamjs · Sep 29, 2023 · c41f68b · c41f68b
1 parent 626e1f6
commit c41f68b
Show file tree

Hide file tree

Showing 82 changed files with 350 additions and 295 deletions.
diff --git a/demos/react-jsnation-workshop/src/components/steps/Step5.tsx b/demos/react-jsnation-workshop/src/components/steps/Step5.tsx
@@ -158,12 +158,12 @@ function Profile({ user }: { user: LocalUser | undefined }): JSX.Element {
 }
 
 class LocalUser {
-  #id: number;
+  readonly id: number;
   #resource: InvalidatableAsync<ApiUser>;
   #invalidate: Marker;
 
   constructor(id: number, data: InvalidatableAsync<ApiUser>, marker: Marker) {
-    this.#id = id;
+    this.id = id;
     this.#resource = data;
     this.#invalidate = marker;
   }

diff --git a/demos/react-jsnation-workshop/src/components/steps/Step6.tsx b/demos/react-jsnation-workshop/src/components/steps/Step6.tsx
@@ -173,12 +173,12 @@ function Profile({ user }: { user: LocalUser | undefined }): JSX.Element {
 }
 
 class LocalUser {
-  #id: number;
+  readonly id: number;
   #resource: InvalidatableAsync<ApiUser>;
   #invalidate: Marker;
 
   constructor(id: number, data: InvalidatableAsync<ApiUser>, marker: Marker) {
-    this.#id = id;
+    this.id = id;
     this.#resource = data;
     this.#invalidate = marker;
   }

diff --git a/demos/react-jsnation/.eslintrc.json b/demos/react-jsnation/.eslintrc.json
@@ -1,5 +1,6 @@
 {
   "root": true,
+  "ignorePatterns": ["node_modules", "dist", "html", "tests"],
   "plugins": ["@starbeam"],
   "overrides": [
     {

diff --git a/demos/react-jsnation/tests/.eslintrc.json b/demos/react-jsnation/tests/.eslintrc.json
@@ -5,7 +5,7 @@
   "overrides": [
     {
       "extends": ["plugin:@starbeam/loose"],
-      "files": ["**/*.ts"],
+      "files": ["**/*.{tsx,ts}"],
       "parserOptions": {
         "project": "tsconfig.json"
       }

diff --git a/demos/react-jsnation/tests/package.json b/demos/react-jsnation/tests/package.json
@@ -5,7 +5,7 @@
   "type": "module",
   "starbeam": {
     "jsx": "react",
-    "source": "ts",
+    "source": "tsx",
     "type": "tests"
   },
   "scripts": {

diff --git a/demos/react-stock-ticker/src/components/Header.tsx b/demos/react-stock-ticker/src/components/Header.tsx
@@ -21,7 +21,7 @@ export default function Header(): JSX.Element {
       event.preventDefault();
 
       const { search } = Object.fromEntries(
-        new FormData(event.currentTarget)
+        new FormData(event.currentTarget),
       ) as {
         search: string;
       };
@@ -86,6 +86,6 @@ export default function Header(): JSX.Element {
         </div>
       </header>
     ),
-    []
+    [],
   );
 }
diff --git a/packages/preact/preact-testing-utils/package.json b/packages/preact/preact-testing-utils/package.json
@@ -14,7 +14,9 @@
     "main": "dist/index.cjs",
     "types": "dist/index.d.ts"
   },
-  "starbeam:type": "library:test-support",
+  "starbeam": {
+    "type": "library:test-support"
+  },
   "scripts": {
     "test:lint": "eslint . --max-warnings 0",
     "test:specs": "vitest --run",

diff --git a/packages/preact/preact-testing-utils/tests/package.json b/packages/preact/preact-testing-utils/tests/package.json
@@ -4,7 +4,7 @@
   "version": "1.0.0",
   "type": "module",
   "starbeam": {
-    "source": "ts",
+    "source": "tsx",
     "type": "tests"
   },
   "scripts": {

diff --git a/packages/preact/preact-utils/package.json b/packages/preact/preact-utils/package.json
@@ -18,7 +18,9 @@
     "main": "dist/index.cjs",
     "types": "dist/index.d.ts"
   },
-  "starbeam:type": "library:public",
+  "starbeam": {
+    "type": "library:public"
+  },
   "scripts": {
     "test:lint": "eslint . --max-warnings 0",
     "test:specs": "vitest --run",

diff --git a/packages/preact/preact-utils/src/plugin.ts b/packages/preact/preact-utils/src/plugin.ts
@@ -266,12 +266,10 @@ class AugmentHandler<F extends AnyFn> implements Handler {
     }
   }
 
-  #name: string;
   #handled = false;
   #original: F;
 
-  private constructor(name: string, original: F) {
-    this.#name = name;
+  private constructor(_name: string, original: F) {
     this.#original = original;
   }
 

diff --git a/packages/preact/preact-utils/tests/package.json b/packages/preact/preact-utils/tests/package.json
@@ -4,7 +4,7 @@
   "version": "1.0.0",
   "type": "module",
   "starbeam": {
-    "source": "ts",
+    "source": "tsx",
     "type": "tests"
   },
   "scripts": {

diff --git a/packages/preact/preact/tests/package.json b/packages/preact/preact/tests/package.json
@@ -4,7 +4,7 @@
   "version": "1.0.0",
   "type": "module",
   "starbeam": {
-    "source": "ts",
+    "source": "tsx",
     "type": "tests"
   },
   "scripts": {

diff --git a/packages/react/react/tests/package.json b/packages/react/react/tests/package.json
@@ -4,7 +4,7 @@
   "version": "1.0.0",
   "type": "module",
   "starbeam": {
-    "source": "ts",
+    "source": "tsx",
     "type": "tests"
   },
   "scripts": {

diff --git a/packages/react/test-utils/package.json b/packages/react/test-utils/package.json
@@ -18,7 +18,9 @@
     "main": "dist/index.cjs",
     "types": "dist/index.d.ts"
   },
-  "starbeam:type": "library:test-support",
+  "starbeam": {
+    "type": "library:test-support"
+  },
   "scripts": {
     "test:lint": "eslint . --max-warnings 0",
     "test:types": "tsc -b"

diff --git a/packages/react/test-utils/src/modes.ts b/packages/react/test-utils/src/modes.ts
@@ -202,6 +202,7 @@ export class SetupTestRoot<Props, T> {
 
       if (lastChecked === undefined || current === undefined) {
         if (lastChecked !== current) {
+          // eslint-disable-next-line no-console
           console.error("Expected current value to equal last checked value", {
             lastChecked,
             current,

diff --git a/packages/react/use-strict-lifecycle/package.json b/packages/react/use-strict-lifecycle/package.json
@@ -19,7 +19,9 @@
     "main": "dist/index.cjs",
     "types": "dist/index.d.ts"
   },
-  "starbeam:type": "library:public",
+  "starbeam": {
+    "type": "library:public"
+  },
   "scripts": {
     "doc": "node ./scripts/doc.js",
     "doc:all": "node ./scripts/docs.js",

diff --git a/packages/react/use-strict-lifecycle/tests/package.json b/packages/react/use-strict-lifecycle/tests/package.json
@@ -4,7 +4,7 @@
   "version": "1.0.0",
   "type": "module",
   "starbeam": {
-    "source": "ts",
+    "source": "tsx",
     "type": "tests"
   },
   "scripts": {

diff --git a/packages/universal/collections/package.json b/packages/universal/collections/package.json
@@ -19,7 +19,9 @@
     "main": "dist/index.cjs",
     "types": "dist/index.d.ts"
   },
-  "starbeam:type": "library:public",
+  "starbeam": {
+    "type": "library:public"
+  },
   "scripts": {
     "test:lint": "eslint . --max-warnings 0",
     "test:specs": "vitest --run",

diff --git a/packages/universal/collections/tests/package.json b/packages/universal/collections/tests/package.json
@@ -4,7 +4,7 @@
   "version": "1.0.0",
   "type": "module",
   "starbeam": {
-    "source": "ts",
+    "source": "tsx",
     "type": "tests"
   },
   "scripts": {

diff --git a/packages/universal/core-utils/package.json b/packages/universal/core-utils/package.json
@@ -18,7 +18,9 @@
     "main": "dist/index.cjs",
     "types": "dist/index.d.ts"
   },
-  "starbeam:type": "library:public",
+  "starbeam": {
+    "type": "library:public"
+  },
   "scripts": {
     "test:lint": "eslint . --max-warnings 0",
     "test:specs": "vitest --run",

diff --git a/packages/universal/core-utils/tests/package.json b/packages/universal/core-utils/tests/package.json
@@ -4,7 +4,7 @@
   "version": "1.0.0",
   "type": "module",
   "starbeam": {
-    "source": "ts",
+    "source": "tsx",
     "type": "tests"
   },
   "scripts": {

diff --git a/packages/universal/core/index.ts b/packages/universal/core/index.ts
@@ -1,4 +1,5 @@
+// eslint-disable-next-line no-console
 console.warn(
-  "WARNING: @starbeam/core has been renamed to @starbeam/universal. Please update your imports to refer to @starbeam/universal."
+  "WARNING: @starbeam/core has been renamed to @starbeam/universal. Please update your imports to refer to @starbeam/universal.",
 );
 export * from "@starbeam/universal";
diff --git a/packages/universal/debug/src/logger.ts b/packages/universal/debug/src/logger.ts
@@ -0,0 +1,34 @@
+/**
+ * This API might gain additional features. For now, its primary purpose is to provide a
+ * sanctioned way to log to the console that is overtly different from explicit
+ * calls to `console.log` (which make it more difficult to identify errant console.logs).
+ */
+export class Logger {
+  static console(): Logger {
+    return new Logger(console);
+  }
+
+  static of(logger: typeof console): Logger {
+    return new Logger(logger);
+  }
+
+  #logger: typeof console;
+
+  private constructor(logger: typeof console) {
+    this.#logger = logger;
+  }
+
+  group(...args: unknown[]): void {
+    this.#logger.group(...args);
+  }
+
+  groupEnd(): void {
+    this.#logger.groupEnd();
+  }
+
+  info(...args: unknown[]): void {
+    this.#logger.info(...args);
+  }
+}
+
+export const LOGGER = Logger.console();
diff --git a/packages/universal/debug/src/tag.ts b/packages/universal/debug/src/tag.ts
@@ -3,19 +3,20 @@ import type { Description, HasTag } from "@starbeam/interfaces";
 import { DEBUG, UNKNOWN_REACTIVE_VALUE } from "@starbeam/reactive";
 import { getDependencies, getTag, lastUpdated } from "@starbeam/tags";
 
+import { LOGGER } from "./logger.js";
 import { Tree } from "./tree.js";
 
 export const debugReactive = (
   tag: HasTag,
   {
     implementation = false,
-  }: { implementation?: boolean; source?: boolean; id?: boolean } = {}
+  }: { implementation?: boolean; source?: boolean; id?: boolean } = {},
 ): string => {
   const dependencies = getDependencies(tag);
   const descriptions = new Set(
     dependencies.map((dependency) =>
-      getDesc(dependency.description, implementation)
-    )
+      getDesc(dependency.description, implementation),
+    ),
   );
 
   const nodes = [...descriptions]
@@ -35,29 +36,31 @@ export const logReactive = (
     implementation?: boolean;
     source?: boolean;
     id?: boolean;
-  } = {}
+  } = {},
 ): void => {
   const debug = debugReactive(tag, options);
 
   if (options.label) {
-    console.group(options.label);
+    LOGGER.group(options.label);
   }
 
-  console.group(
-    describe(getTag(tag).description, { id: options.id }),
-    `(updated at ${lastUpdated(tag).at})`
-  );
-  console.info(debug);
-  console.groupEnd();
+  {
+    LOGGER.group(
+      describe(getTag(tag).description, { id: options.id }),
+      `(updated at ${lastUpdated(tag).at})`,
+    );
+    LOGGER.info(debug);
+    LOGGER.groupEnd();
+  }
 
   if (options.label) {
-    console.groupEnd();
+    LOGGER.groupEnd();
   }
 };
 
 function describe(
   description: Description | undefined,
-  options?: { id: boolean | undefined }
+  options?: { id: boolean | undefined },
 ): string {
   return description && DEBUG
     ? DEBUG.describe(description, options)
@@ -66,7 +69,7 @@ function describe(
 
 function getDesc(
   description: Description | undefined,
-  showImplementation: boolean
+  showImplementation: boolean,
 ): Description | undefined {
   return showImplementation ? description : DEBUG?.getUserFacing(description);
 }
diff --git a/packages/universal/debug/tests/package.json b/packages/universal/debug/tests/package.json
@@ -4,7 +4,7 @@
   "version": "1.0.0",
   "type": "module",
   "starbeam": {
-    "source": "ts",
+    "source": "tsx",
     "type": "tests"
   },
   "scripts": {

diff --git a/packages/universal/modifier/package.json b/packages/universal/modifier/package.json
@@ -18,7 +18,9 @@
     "main": "dist/index.cjs",
     "types": "dist/index.d.ts"
   },
-  "starbeam:type": "library:public",
+  "starbeam": {
+    "type": "library:public"
+  },
   "scripts": {
     "test:lint": "eslint . --max-warnings 0",
     "test:types": "tsc -b"

diff --git a/packages/universal/reactive/package.json b/packages/universal/reactive/package.json
@@ -18,7 +18,9 @@
     "main": "dist/index.cjs",
     "types": "dist/index.d.ts"
   },
-  "starbeam:type": "library:public",
+  "starbeam": {
+    "type": "library:public"
+  },
   "scripts": {
     "test:lint": "eslint . --max-warnings 0",
     "test:specs": "vitest --run",

diff --git a/packages/universal/reactive/tests/package.json b/packages/universal/reactive/tests/package.json
@@ -4,7 +4,7 @@
   "version": "1.0.0",
   "type": "module",
   "starbeam": {
-    "source": "ts",
+    "source": "tsx",
     "type": "tests"
   },
   "scripts": {

diff --git a/packages/universal/renderer/package.json b/packages/universal/renderer/package.json
@@ -18,7 +18,9 @@
     "main": "dist/index.cjs",
     "types": "dist/index.d.ts"
   },
-  "starbeam:type": "library:public",
+  "starbeam": {
+    "type": "library:public"
+  },
   "scripts": {
     "test:lint": "eslint . --max-warnings 0",
     "test:specs": "vitest --run",