Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P0] Prohibit SDPA Attention Use in Pyvene #202

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

PinetreePantry
Copy link
Collaborator

Description

Fix Pyvene 101 by prohibiting SDPA Attention Use

Testing Done

Checklist:

  • My PR title strictly follows the format: [Your Priority] Your Title
  • [] I have attached the testing log above
  • I provide enough comments to my code
  • [] I have changed documentations
  • [] I have added tests for my changes

Until we find a permanent solution
@PinetreePantry
Copy link
Collaborator Author

There are some other bugs associated with Pyvene 101/102. I will fix those soon

Copy link
Collaborator

@frankaging frankaging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Check in conditioned on the test.

@PinetreePantry PinetreePantry merged commit f5119c1 into main Jan 28, 2025
2 of 3 checks passed
@PinetreePantry
Copy link
Collaborator Author

Test is another P0 bug (#201)
I will take a look of that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants