Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Cases for Causal Model, MQNLI Intro Notebook #131

Merged
merged 2 commits into from
Mar 16, 2024

Conversation

amirzur2023
Copy link

Created tests for causal model data generation, and patched bugs in the counterfactual data generation method. Created MQNLI notebook to introduce DAS for a nested hierarchical causal model.

Description

Created files:

  • /tests/unit_tests/CausalModelTestCase.py - testing for causal_model.py.
  • tutorials/advanced_tutorials/MQNLI.ipynb - notebook working through the MQNLI dataset introduced in Geiger, Cases, Karttunen, Potts (2019).
  • cont_signature.json, empty_signature.json, neg_cont_signature.json, neg_signature.json, q_projectivity.json - helper files for the MQNLI notebook.

Edited files:

  • data_generators/causal_model.py - fixed minor bugs in factual and counterfactual data generation functions.
  • tutorials/advanced_tutorials/DAS_Main_Introduction.ipynb - updated to follow new structure in causal_model.py (only other file in repo that is currently using causal_model.py).

Testing Done

Introduced test cases for causal_model.py, ran MQNLI and DAS Introduction notebooks successfully.

….py and introduced tests for causal model code;, updated DAS main introduction to match new causal model schematic; created notebook for MQNLI dataset exploring DAS on a nested heirarchical causal structure
Copy link
Collaborator

@frankaging frankaging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! Could you put those *.json data files into the tutorial data folder? Thanks!

@frankaging frankaging merged commit a2b8e3a into stanfordnlp:main Mar 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants