Skip to content

fix linked item issues in Super editor #2918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antsgar merged 3 commits into from
Jul 21, 2025
Merged

fix linked item issues in Super editor #2918

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e010eb
fix: Fix items being embedded twice when linking them in a Super note
antsgar Jul 19, 2025
1bb2e5b
fix: Fix remove button not working for embedded linked items in Super…
antsgar Jul 19, 2025
de2697a
remove unnecessary change
antsgar Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions packages/web/src/javascripts/Components/LinkedItems/LinkedItemBubble.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,10 @@ const LinkedItemBubble = ({
setShowUnlinkButton(true)
}

const onBlur = () => {
setShowUnlinkButton(false)
const onBlur: React.FocusEventHandler<HTMLButtonElement | HTMLAnchorElement> = (event) => {
if (!event.currentTarget.contains(event.relatedTarget)) {
setShowUnlinkButton(false)
}
setWasClicked(false)
}

Expand Down Expand Up @@ -131,8 +133,10 @@ const LinkedItemBubble = ({
<button
ref={(el) => (unlinkButtonRef.current = el as HTMLElement)}
role="button"
className="-mr-1 ml-2 inline-flex cursor-pointer border-0 bg-transparent p-0 h-[1.15em] align-middle"
onClick={onUnlinkClick}
className="-mr-1 ml-2 inline-flex h-[1.15em] cursor-pointer border-0 bg-transparent p-0 align-middle"
onClick={(event) => {
onUnlinkClick(event)
}}
>
<Icon type="close" className="text-neutral hover:text-info" size="small" />
</button>
Expand Down
14 changes: 5 additions & 9 deletions ...src/javascripts/Components/SuperEditor/Plugins/ItemBubblePlugin/Nodes/BubbleComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,11 @@ export function BubbleComponent({ itemUuid, node }: BubbleComponentProps) {
[toggleAppPane, linkingController],
)

const unlinkPressed = useCallback(
async (itemToUnlink: LinkableItem) => {
linkingController.unlinkItemFromSelectedItem(itemToUnlink).catch(console.error)
editor.update(() => {
node.remove()
})
},
[linkingController, node, editor],
)
const unlinkPressed = useCallback(async () => {
Copy link
Contributor Author

@antsgar antsgar Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual unlinking here is unnecessary because it happens through the NodeObserverPlugin

Copy link
Member

@amanharwara amanharwara Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, was just about to ask that.

editor.update(() => {
node.remove()
})
}, [linkingController, node, editor])

if (!item) {
return <div>Unable to find item {itemUuid}</div>
Expand Down
8 changes: 1 addition & 7 deletions ...scripts/Components/SuperEditor/Plugins/ItemSelectionPlugin/ItemSelectionItemComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,7 @@ export function ItemSelectionItemComponent({ index, isSelected, onClick, onMouse
onClick={onClick}
>
{option.item && <LinkedItemMeta item={option.item} searchQuery={searchQuery} />}
{!option.item && (
<LinkedItemSearchResultsAddTagOption
searchQuery={searchQuery}
onClickCallback={onClick}
isFocused={isSelected}
/>
)}
{!option.item && <LinkedItemSearchResultsAddTagOption searchQuery={searchQuery} isFocused={isSelected} />}
</li>
)
}
Loading