Remove non-alphanumerics (except quotes) from search query #486
+6
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is, don't replace non-alphanumerics with a space. This matches the behavior of Formatter::RemoveDiacriticsAndNonalphanumerics(), which would be used here except that function would also remove quotes. We actually discussed not introducing spaces previously, but I made a mistake and didn't apply the same change to the user's search query: #470 (comment)
This change fixes queries with compound words like:
Haycraft-Queen
and also fixes queries for authors with apostrophes:
O'Neill
No changes to existing DBs are necessary because they already have terms like
haycraftqueen
andoneill
stored inIndexableCollections
andIndexableAuthors
.Fixes #484