[1.0] Remove deprecations

Merge pull request #460 from stan-dev/remove-deprecations

.pylintrc

@@ -76,7 +76,7 @@ disable=bad-continuation,
     consider-using-with,
     consider-using-dict-items,
     unspecified-encoding,
-    consider-using-f-string
+    consider-using-f-string,
 
 # Enable the message, report, category or checker with the given id(s). You can
 # either give multiple identifier separated by comma (,) or put this option

cmdstanpy/__init__.py

@@ -22,7 +22,6 @@
 _CMDSTAN_SAMPLING = 1000
 _CMDSTAN_THIN = 1
 _CMDSTAN_REFRESH = 100
-_DOT_CMDSTANPY = '.cmdstanpy'
 _DOT_CMDSTAN = '.cmdstan'
 
 

cmdstanpy/cmdstan_args.py

@@ -1,7 +1,6 @@
 """
 CmdStan arguments
 """
-import logging
 import os
 from enum import Enum, auto
 from time import time
@@ -721,7 +720,6 @@ def __init__(
         save_latent_dynamics: bool = False,
         save_profile: bool = False,
         refresh: Optional[int] = None,
-        logger: Optional[logging.Logger] = None,
     ) -> None:
         """Initialize object."""
         self.model_name = model_name
@@ -745,11 +743,6 @@ def __init__(
         elif isinstance(method_args, VariationalArgs):
             self.method = Method.VARIATIONAL
         self.method_args.validate(len(chain_ids) if chain_ids else None)
-        if logger is not None:
-            get_logger().warning(
-                "Parameter 'logger' is deprecated."
-                " Control logging behavior via logging.getLogger('cmdstanpy')"
-            )
         self.validate()
 
     def validate(self) -> None:

cmdstanpy/compiler_opts.py

@@ -2,7 +2,6 @@
 Makefile options for stanc and C++ compilers
 """
 
-import logging
 import os
 from pathlib import Path
 from typing import Any, Dict, List, Optional, Union
@@ -57,17 +56,11 @@ def __init__(
         stanc_options: Optional[Dict[str, Any]] = None,
         cpp_options: Optional[Dict[str, Any]] = None,
         user_header: Optional[str] = None,
-        logger: Optional[logging.Logger] = None,
     ) -> None:
         """Initialize object."""
         self._stanc_options = stanc_options if stanc_options is not None else {}
         self._cpp_options = cpp_options if cpp_options is not None else {}
         self._user_header = user_header if user_header is not None else ''
-        if logger is not None:
-            get_logger().warning(
-                "Parameter 'logger' is deprecated."
-                " Control logging behavior via logging.getLogger('cmdstanpy')"
-            )
 
     def __repr__(self) -> str:
         return 'stanc_options={}, cpp_options={}'.format(

cmdstanpy/install_cmdstan.py

@@ -30,11 +30,10 @@
 
 from tqdm.auto import tqdm
 
-from cmdstanpy import _DOT_CMDSTAN, _DOT_CMDSTANPY
+from cmdstanpy import _DOT_CMDSTAN
 from cmdstanpy.utils import (
     cmdstan_path,
     do_command,
-    get_logger,
     pushd,
     validate_dir,
     wrap_url_progress_hook,
@@ -465,15 +464,6 @@ def main(args: Dict[str, Any]) -> None:
         )
 
     cmdstan_dir = os.path.expanduser(os.path.join('~', _DOT_CMDSTAN))
-    if not os.path.exists(cmdstan_dir):
-        cmdstanpy_dir = os.path.expanduser(os.path.join('~', _DOT_CMDSTANPY))
-        if os.path.exists(cmdstanpy_dir):
-            cmdstan_dir = cmdstanpy_dir
-            get_logger().warning(
-                "Using ~/.cmdstanpy is deprecated and"
-                " will not be automatically detected in version 1.0!\n"
-                " Please rename to ~/.cmdstan"
-            )
 
     install_dir = cmdstan_dir
     if args['dir']:

cmdstanpy/install_cxx_toolchain.py

@@ -23,9 +23,8 @@
 from time import sleep
 from typing import Any, Dict, List
 
-from cmdstanpy import _DOT_CMDSTAN, _DOT_CMDSTANPY
+from cmdstanpy import _DOT_CMDSTAN
 from cmdstanpy.utils import (
-    get_logger,
     pushd,
     validate_dir,
     wrap_url_progress_hook,
@@ -285,19 +284,7 @@ def main(args: Dict[str, Any]) -> None:
 
     install_dir = args['dir']
     if install_dir is None:
-        cmdstan_dir = os.path.expanduser(os.path.join('~', _DOT_CMDSTAN))
-        if not os.path.exists(cmdstan_dir):
-            cmdstanpy_dir = os.path.expanduser(
-                os.path.join('~', _DOT_CMDSTANPY)
-            )
-            if os.path.exists(cmdstanpy_dir):
-                cmdstan_dir = cmdstanpy_dir
-                get_logger().warning(
-                    "Using ~/.cmdstanpy is deprecated and"
-                    " will not be automatically detected in version 1.0!\n"
-                    " Please rename to ~/.cmdstan"
-                )
-        install_dir = cmdstan_dir
+        install_dir = os.path.expanduser(os.path.join('~', _DOT_CMDSTAN))
     validate_dir(install_dir)
     print('Install directory: {}'.format(install_dir))
 

cmdstanpy/model.py

@@ -1,7 +1,6 @@
 """CmdStanModel"""
 
 import io
-import logging
 import os
 import platform
 import re
@@ -91,7 +90,6 @@ def __init__(
         stanc_options: Optional[Dict[str, Any]] = None,
         cpp_options: Optional[Dict[str, Any]] = None,
         user_header: Optional[str] = None,
-        logger: Optional[logging.Logger] = None,
     ) -> None:
         """
         Initialize object given constructor args.
@@ -113,11 +111,6 @@ def __init__(
             cpp_options=cpp_options,
             user_header=user_header,
         )
-        if logger is not None:
-            get_logger().warning(
-                "Parameter 'logger' is deprecated."
-                " Control logging behavior via logging.getLogger('cmdstanpy')"
-            )
 
         if model_name is not None:
             if not model_name.strip():