This repository was archived by the owner on Apr 21, 2023. It is now read-only.
Updated navigation and section changed english to bangla#189
Open
kmdshojib wants to merge 28 commits intostale-reactjs-org-translations:mainfrom
Open
Updated navigation and section changed english to bangla#189kmdshojib wants to merge 28 commits intostale-reactjs-org-translations:mainfrom
kmdshojib wants to merge 28 commits intostale-reactjs-org-translations:mainfrom
Conversation
kmdshojib
changed the title
Author
|
Translated passing data through props |
shakib609
suggested changes
Jul 25, 2022
Contributor
shakib609
left a comment
shakib609
left a comment
There was a problem hiding this comment.
Hello @kmdshojib
Thanks a lot for the initiative.
I have checked the PR and file changes to provide some feedbacks.
I have mentioned, the changes required for your changes to be merged.
Looking forward to your changes and more contributions from you.
| @@ -0,0 +1,5 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
This vscode specific file can not be included into the repository.
Co-authored-by: Shakib Hossain <3992124+shakib609@users.noreply.github.com>
Co-authored-by: Shakib Hossain <3992124+shakib609@users.noreply.github.com>
Co-authored-by: Shakib Hossain <3992124+shakib609@users.noreply.github.com>
Co-authored-by: Shakib Hossain <3992124+shakib609@users.noreply.github.com>
Co-authored-by: Shakib Hossain <3992124+shakib609@users.noreply.github.com>
Co-authored-by: Shakib Hossain <3992124+shakib609@users.noreply.github.com>
Co-authored-by: Shakib Hossain <3992124+shakib609@users.noreply.github.com>
Co-authored-by: Shakib Hossain <3992124+shakib609@users.noreply.github.com>
Co-authored-by: Shakib Hossain <3992124+shakib609@users.noreply.github.com>
Co-authored-by: Shakib Hossain <3992124+shakib609@users.noreply.github.com>
Co-authored-by: Shakib Hossain <3992124+shakib609@users.noreply.github.com>
Co-authored-by: Shakib Hossain <3992124+shakib609@users.noreply.github.com>
Co-authored-by: Shakib Hossain <3992124+shakib609@users.noreply.github.com>
Co-authored-by: Shakib Hossain <3992124+shakib609@users.noreply.github.com>
Co-authored-by: Shakib Hossain <3992124+shakib609@users.noreply.github.com>
Co-authored-by: Shakib Hossain <3992124+shakib609@users.noreply.github.com>
Co-authored-by: Shakib Hossain <3992124+shakib609@users.noreply.github.com>
Co-authored-by: Shakib Hossain <3992124+shakib609@users.noreply.github.com>
Co-authored-by: Shakib Hossain <3992124+shakib609@users.noreply.github.com>
Co-authored-by: Shakib Hossain <3992124+shakib609@users.noreply.github.com>
Co-authored-by: Shakib Hossain <3992124+shakib609@users.noreply.github.com>
Co-authored-by: Shakib Hossain <3992124+shakib609@users.noreply.github.com>
shakib609
suggested changes
Jul 31, 2022
Contributor
shakib609
left a comment
shakib609
left a comment
There was a problem hiding this comment.
The line numbers still don't match after the corrections. There are a few extra new lines left in the Bengali translation. The lines must match with the english version so that the translations can be updated accordingly once the english documentation gets updated.
Author
|
Can you specify which lines are not matching? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have changed the navigation
Overview
What is react
Inspecting the Starter Code