Skip to content

Conversation

@brice-stacks
Copy link
Contributor

stacks-inspect validate-block was not correctly handling the partial extends, so it was incorrectly reporting bad block costs.

`stacks-inspect validate-block` was not correctly handling the partial
extends, so it was incorrectly reporting bad block costs.
aaronb-stacks
aaronb-stacks previously approved these changes Jan 6, 2026
Copy link
Contributor

@aaronb-stacks aaronb-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

benjamin-stacks
benjamin-stacks previously approved these changes Jan 6, 2026
Copy link

@benjamin-stacks benjamin-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes maybe 80% sense to me, it seems coherent, and Aaron gave a thumbs up. Good enough 😅

@brice-stacks brice-stacks added this pull request to the merge queue Jan 6, 2026
@aaronb-stacks aaronb-stacks removed this pull request from the merge queue due to a manual request Jan 6, 2026
@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

❌ Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.25%. Comparing base (267c7ef) to head (e1fff6c).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
contrib/stacks-inspect/src/lib.rs 0.00% 26 Missing ⚠️

❌ Your project status has failed because the head coverage (76.25%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6786      +/-   ##
===========================================
- Coverage    78.40%   76.25%   -2.16%     
===========================================
  Files          585      585              
  Lines       361384   361397      +13     
===========================================
- Hits        283360   275590    -7770     
- Misses       78024    85807    +7783     
Files with missing lines Coverage Δ
contrib/stacks-inspect/src/lib.rs 4.98% <0.00%> (-0.08%) ⬇️

... and 97 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 267c7ef...e1fff6c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brice-stacks brice-stacks requested a review from wileyj January 6, 2026 20:32
@brice-stacks brice-stacks enabled auto-merge January 6, 2026 20:33
@brice-stacks brice-stacks added this pull request to the merge queue Jan 7, 2026
Merged via the queue into stacks-network:develop with commit 94c7832 Jan 7, 2026
310 of 313 checks passed
@brice-stacks brice-stacks deleted the fix/stacks-inspect-partial-extends branch January 7, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants