-
Notifications
You must be signed in to change notification settings - Fork 723
fix: handle partial extends in block validation #6786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle partial extends in block validation #6786
Conversation
`stacks-inspect validate-block` was not correctly handling the partial extends, so it was incorrectly reporting bad block costs.
aaronb-stacks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
benjamin-stacks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes maybe 80% sense to me, it seems coherent, and Aaron gave a thumbs up. Good enough 😅
e1fff6c
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (76.25%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #6786 +/- ##
===========================================
- Coverage 78.40% 76.25% -2.16%
===========================================
Files 585 585
Lines 361384 361397 +13
===========================================
- Hits 283360 275590 -7770
- Misses 78024 85807 +7783
... and 97 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
94c7832
stacks-inspect validate-blockwas not correctly handling the partial extends, so it was incorrectly reporting bad block costs.