Workspace level profiles

[sergey-shandar]

Description

Applicable issues

• fixes Set opt-level on workspace level #3835

Additional info (benefits, drawbacks, caveats)

Checklist

• Test coverage for new or modified code paths
• Changelog is updated
• Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
• New clarity functions have corresponding PR in clarity-benchmarking repo
• New integration test(s) added to bitcoin-tests.yml

[codecov]

Codecov Report

Merging #3838 (c356b84) into develop (b820596) will decrease coverage by 0.02%.
Report is 5 commits behind head on develop.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #3838      +/-   ##
===========================================
- Coverage     0.18%    0.16%   -0.02%     
===========================================
  Files          306      305       -1     
  Lines       280746   280694      -52     
===========================================
- Hits           512      469      -43     
+ Misses      280234   280225       -9     

Files Changed	Coverage Δ
clarity/src/vm/types/serialization.rs	0.00% <0.00%> (ø)
stackslib/src/blockstack_cli.rs	0.00% <0.00%> (ø)
stackslib/src/burnchains/affirmation.rs	0.00% <ø> (ø)
stackslib/src/burnchains/bitcoin/address.rs	0.00% <ø> (ø)
stackslib/src/burnchains/bitcoin/bits.rs	0.00% <ø> (ø)
stackslib/src/burnchains/bitcoin/blocks.rs	0.00% <ø> (ø)
stackslib/src/burnchains/bitcoin/indexer.rs	0.00% <ø> (ø)
stackslib/src/burnchains/bitcoin/mod.rs	0.00% <ø> (ø)
stackslib/src/burnchains/bitcoin/network.rs	0.00% <ø> (ø)
stackslib/src/burnchains/bitcoin/spv.rs	0.00% <ø> (ø)
... and 132 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[kantai]

I'd drop this specification, since it gets set to 3 above anyways.

[kantai]

@sergey-shandar -- thanks for opening this. I also opened a similar PR #3836.

I don't think we should actually remove the profile settings from the workspace members yet, though. clarity, in particular, can be published by itself, and in that case, the profile settings from its Cargo file are actually used. There's a long-standing open issue about that cargo warning here (rust-lang/cargo#8264), and I'm inclined to just let that warning continue to echo in our case, because we do often need to define workspace member profiles

[sergey-shandar]

@sergey-shandar -- thanks for opening this. I also opened a similar PR #3836.

I don't think we should actually remove the profile settings from the workspace members yet, though. clarity, in particular, can be published by itself, and in that case, the profile settings from its Cargo file are actually used. There's a long-standing open issue about that cargo warning here (rust-lang/cargo#8264), and I'm inclined to just let that warning continue to echo in our case, because we do often need to define workspace member profiles

It depends how do you build clarity or any other packages. For example, if you build and publish it from a repository root, then it will always use workspace settings. Also, if you reference clarity using git URL clarity = { git = "https://github.com/stacks-network/stacks-blockchain/", branch = "develop" } it will also use workspace settings.

[kantai]

@sergey-shandar -- thanks for opening this. I also opened a similar PR #3836.

I don't think we should actually remove the profile settings from the workspace members yet, though. clarity, in particular, can be published by itself, and in that case, the profile settings from its Cargo file are actually used. There's a long-standing open issue about that cargo warning here (rust-lang/cargo#8264), and I'm inclined to just let that warning continue to echo in our case, because we do often need to define workspace member profiles

It depends how do you build clarity or any other package. For example, if you build and publish it from a repository root, then it will always use workspace settings. Also, if you reference clarity using git URL clarity = { git = "https://github.com/stacks-network/stacks-blockchain/", branch = "develop" } it will also use workspace settings.

Ah, in that case, I think that's fine.

[kantai]

This LGTM, but please drop the regex specific opt-level setting

[sergey-shandar]

@kantai could you make sure that this PR is fixing an issue with CI time?

[blockstack-devops]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.