Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
TextEditor
control for editing multi-line text. For now it's borderless (i.e. has all platform-specific 'text field' looking styles disabled) to allow for it to be used in the widest variety of use cases.The text editor background in the NotesExample app (see screenshots below) was added using the
background
modifier and doesn't come with the text editor (unstyled by default).Other changes
cmd+a
,cmd+c
,cmd+v
etc to be used in text inputs.background
modifier's propagation ofidealHeightForWidth
andidealWidthForHeight
(previously just set to the child view'sidealSize.x
andidealSize.y
)ScrollView
's sizing behaviour (to a certain extent; just enough to fixNotesExample
)Known issues
Future directions
textEditorStyle
modifier to allow platform-specific decorations to be enabled (so that text editors can fit in with text fields for form-like use cases)Screenshots
AppKit
WinUI
Gtk 4
Gtk 3
The missing border radius is a known issue for Gtk3Backend.
UIKit