Skip to content

Conversation

@yago-123
Copy link

@yago-123 yago-123 commented Oct 15, 2025

Description

Introduce waiters for Intake Runners, Intakes and Intake Users. This PR is required as part of STACKIT Intake addition in the CLI.

Checklist

  • Issue was linked above
  • No generated code was adjusted manually (check comments in file header)
  • Changelogs
    • Changelog in the root directory was adjusted (see here)
    • Changelog(s) of the service(s) were adjusted (see e.g. here)
  • VERSION file(s) of the service(s) were adjusted
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@rubenhoenle
Copy link
Member

@yago-123 is this ready for review? Is there a reason this PR is still in draft state?

@rubenhoenle rubenhoenle self-assigned this Oct 16, 2025
@yago-123
Copy link
Author

@yago-123 is this ready for review? Is there a reason this PR is still in draft state?

I'm doing the examples part, I plan on asking for review today

@yago-123
Copy link
Author

yago-123 commented Oct 16, 2025

make fmt does not exist, so skipping that step. Linting is failing due to the fact that the wait package is added as part of the PR. Maybe we need to split the work in two PRs.

@yago-123 yago-123 marked this pull request as ready for review October 16, 2025 13:50
@yago-123 yago-123 requested a review from a team as a code owner October 16, 2025 13:50
@yago-123 yago-123 requested a review from rubenhoenle October 17, 2025 10:58
@github-actions
Copy link

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants