Skip to content

Synchronise master with upstream #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
priteau merged 2 commits into from
Nov 3, 2025
Merged

Synchronise master with upstream #491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5eb4cbc
Account for encoding in _get_direct_url
IanWatson92 Oct 23, 2025
ac156f4
Merge "Account for encoding in _get_direct_url"
Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion kayobe/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
import shutil
import subprocess
import sys
from urllib.parse import unquote
from urllib.parse import urlparse

from ansible.parsing.yaml.loader import AnsibleLoader
import yaml
Expand Down Expand Up @@ -67,7 +69,7 @@ def _get_direct_url_if_editable(dist):
url = direct_url_content['url']
prefix = 'file://'
if url.startswith(prefix):
return url[len(prefix):]
return unquote(urlparse(url).path)

return None

Expand Down
7 changes: 7 additions & 0 deletions releasenotes/notes/fix-working-dir-url-encoding-5f50d66547858e37.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
fixes:
- |
Fixes a issue where the working directory contains symbols such
as @.
The previous behaviour tries to load files with url encoded symbols.
`LP#2129687 <https://bugs.launchpad.net/kayobe/+bug/2129687>`__