Draft
Conversation
… active format/block recognition, formik and local draft mdast transformations; node selections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements a conditional WYSIWYG mode that aims at providing lossless transformations between Markdown and WYSIWYG through our MDAST pipeline.
Introduces the support for
NodeSelectionwhich can be seen as collapsed selections relative to the nearest node or literal selected blocks (likeMediaNode), and a reactive (only WYSIWYG) toolbar that shows what block or format you're currently on.Screenshots
Additional Context
Linebreaks are available in WYSIWYG mode and this can break Android's experience. Perhaps we should replace linebreaks with a character that some Android IMEs don’t recognize, thereby circumventing the limitations of their buggy implementations.
Going forward, we'll need to provide a markdown equivalent for special Lexical stuff like text alignment. To speed up development, that should be postponed to Stage 4.
Plugins Parity
Some plugins or extensions are made for Markdown mode and should also support WYSIWYG:
FileUploadPluginMentionsPluginAppendValuePluginChecklist
Are your changes backward compatible? Please answer below:
For example, a change is not backward compatible if you removed a GraphQL field or dropped a database column.
tbd
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
3, iterative QA
For frontend changes: Tested on mobile, light and dark mode? Please answer below:
tbd
Did you introduce any new environment variables? If so, call them out explicitly here:
n/a
Did you use AI for this? If so, how much did it assist you?
tbd