Check and handling of reciver wallet errors#2748
Open
pory-gone wants to merge 2 commits intostackernews:masterfrom
Open
Check and handling of reciver wallet errors#2748pory-gone wants to merge 2 commits intostackernews:masterfrom
pory-gone wants to merge 2 commits intostackernews:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Feat #2468
When zapping fails due to receiver wallet errors (
INVOICE_CREATION_FAILEDorINVOICE_WRAPPING_FAILED_*), the sender now sees a clear error message in their wallet logs.Screenshots
N/A
Additional Context
The implementation follows the existing pattern in payInFailed() by checking for receiver wallet errors after successful state transition.
Checklist
Are your changes backward compatible? Please answer below:
Yes
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
6/10
For frontend changes: Tested on mobile, light and dark mode? Please answer below:
N/A
Did you introduce any new environment variables? If so, call them out explicitly here:
No
Did you use AI for this? If so, how much did it assist you?
AI helped me understand how the components that handle payment errors work