Don't detect mentions in code blocks#2726
Open
judemont wants to merge 1 commit intostackernews:masterfrom
Open
Don't detect mentions in code blocks#2726judemont wants to merge 1 commit intostackernews:masterfrom
judemont wants to merge 1 commit intostackernews:masterfrom
Conversation
Member
|
@Soxasora would it be possible to use some of the editor tooling to pull out mentions/images etc? This regex stuff is brittle and we already do this robustly in the editor. |
Member
Yes, we can create a I need to continue the docs that I sadly de-prioritized for bugfixing, sorry about that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix: #2589
Don't detect mentions in code blocks and don't notify users.
Screenshots
Additional Context
Checklist
Are your changes backward compatible? Please answer below:
For example, a change is not backward compatible if you removed a GraphQL field or dropped a database column.
Yes, they are.
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
8/10, I have manually tested
For frontend changes: Tested on mobile, light and dark mode? Please answer below:
N/A
Did you introduce any new environment variables? If so, call them out explicitly here:
No
Did you use AI for this? If so, how much did it assist you?
I used AI for the regex string.