Skip to content

Don't detect mentions in code blocks#2726

Open
judemont wants to merge 1 commit intostackernews:masterfrom
judemont:master
Open

Don't detect mentions in code blocks#2726
judemont wants to merge 1 commit intostackernews:masterfrom
judemont:master

Conversation

@judemont
Copy link

@judemont judemont commented Dec 28, 2025

Description

fix: #2589
Don't detect mentions in code blocks and don't notify users.

Screenshots

Additional Context

Checklist

Are your changes backward compatible? Please answer below:

For example, a change is not backward compatible if you removed a GraphQL field or dropped a database column.
Yes, they are.
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
8/10, I have manually tested

For frontend changes: Tested on mobile, light and dark mode? Please answer below:
N/A

Did you introduce any new environment variables? If so, call them out explicitly here:
No

Did you use AI for this? If so, how much did it assist you?
I used AI for the regex string.

@huumn
Copy link
Member

huumn commented Dec 28, 2025

@Soxasora would it be possible to use some of the editor tooling to pull out mentions/images etc? This regex stuff is brittle and we already do this robustly in the editor.

@Soxasora
Copy link
Member

Soxasora commented Dec 28, 2025

would it be possible to use some of the editor tooling to pull out mentions/images etc?

Yes, we can create a lexicalState on the spot (like with item creation, we can bundle lexicalState with item) or pick the one we use for items via DataLoader.
This opens a huge amount of possibilities, in this case we can either search nodes of type userMentionNode inside the lexicalState object or load this state on an headless editor and run lexical dollar functions such as $getNodesByType().

I need to continue the docs that I sadly de-prioritized for bugfixing, sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Users are notified of mentions in code blocks

3 participants