Conversation
Can we have full width stats?
Member
|
I'm not sure embeds (iframes) will work with redirects. If it does work, I'll need to review njump.to to confirm I can trust the njump sources if we're giving them a CSP hallpass. |
Member
|
... the embeds are janky. we shouldn't need them really and should be able to fetch nostr stuff ourselves ... it's just more code to maintain ... so if we shouldn't/can't do these embeds, it might be time to remove them |
Author
|
True I did not evaluate the embeddings visualization; I simply replaced anything njump. Removing embeds (for nostr notes) could be a good move, as it forces stackers to fill the description input with some content to provide more value to the post. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Njump to is a proxy that redirects to a random njump instance. More info at https://github.com/dergigi/njump-to
Screenshots
Additional Context
Sometimes njum.me is overflooded and does not load
Checklist
Are your changes backward compatible? Please answer below:
Yes
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
10
For frontend changes: Tested on mobile, light and dark mode? Please answer below:
N/A
Did you introduce any new environment variables? If so, call them out explicitly here:
No
Did you use AI for this? If so, how much did it assist you?
No