Filter push notifications using satsFilterClause in SQL#2673
Open
pory-gone wants to merge 2 commits intostackernews:masterfrom
Open
Filter push notifications using satsFilterClause in SQL#2673pory-gone wants to merge 2 commits intostackernews:masterfrom
pory-gone wants to merge 2 commits intostackernews:masterfrom
Conversation
pory-gone
changed the title
pory-gone
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix #2438
Added
satsFiltercheck to push notification queries.Changes:
satsFilterClause()helper function that replicates the logic frominvestmentClauseinitem.js-Modified
notifyUserSubscribers,notifyTerritorySubscribers,notifyThreadSubscribers,notifyItemParents,notifyMention, andnotifyItemMentionto filter based onsatsFilterdirectly in the SQL queryyScreenshots
N/A
Additional Context
The filter is applied at the SQL query level rather than in
sendUserNotificationto ensure the filter is applied beforenotification.itemIdis deleted.I haven't been able to test properly with the freebies since they've been disabled, but tests show the filter works.
Checklist
Are your changes backward compatible? Please answer below:
Yes
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
7/10
For frontend changes: Tested on mobile, light and dark mode? Please answer below:
NaN
Did you introduce any new environment variables? If so, call them out explicitly here:
NaN
Did you use AI for this? If so, how much did it assist you?
AI helped me with a detailed explanation of the code and a testing plan to verify that the changes worked correctly.