Open
Conversation
pory-gone
force-pushed
the
weird_refresh_pwa
branch
from
ce83649 to
e7724b0
Compare
Soxasora
approved these changes
Dec 28, 2025
Member
Soxasora
left a comment
Soxasora
left a comment
There was a problem hiding this comment.
You successfully disabled native Android's pull to refresh by also adding the overscroll-behavior-y: contain to <html>.
Great catch!
It works great, here's a before and after video (remember to do videos!)
screen-20251228-135544.2.mp4
I also tested with iOS, to see if something broke, and it's working as expected.
We need to see if this will cause some browsers (edge case) to work weirdly with some of our modals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix #2658
Fixed three PWA Pull-To_refresh bugs on Android Chrome.
Added
e.preventDefault()inhandleTouchMoveto block native PTR, also added{ passive: false }to touch event listeners required for prefentDefault.Called
NProgress.done()beforerouter.replace()to prevent multiple loading bars.Changed from
router.push()torouter.replace()for cleaner navigation.Screenshots
video_2025-11-26_19-25-48.mp4
Additional Context
The fix was tested on Android PWA standalone mode via cloudflare tunnel. Added a timeout for the pull down to prevent the PTR native of chrome to appear.
Checklist
Are your changes backward compatible? Please answer below:
Yes
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
8/10
For frontend changes: Tested on mobile, light and dark mode? Please answer below:
Tested on Android mobile PWA in both modes.
Did you introduce any new environment variables? If so, call them out explicitly here:
NaN
Did you use AI for this? If so, how much did it assist you?
I used AI to understand how to test the PWA standalone on my phone