Skip to content

fix: Adding sed compatibility for MacOS #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025
Merged

Conversation

Maleware
Copy link
Member

This PR adds:

  • compatibility increase for MacOS for NixOS powered dev tools

@Maleware Maleware self-assigned this May 16, 2025
@Maleware Maleware changed the title Adding sed compatibility for MacOS fix: Adding sed compatibility for MacOS May 16, 2025
@Maleware Maleware requested a review from a team May 16, 2025 11:18
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Maleware Maleware added this pull request to the merge queue May 16, 2025
Merged via the queue into main with commit 43b0ebd May 16, 2025
2 checks passed
@Maleware Maleware deleted the fix/mac-compatibility branch May 16, 2025 11:54
@nightkr
Copy link
Member

nightkr commented May 16, 2025

I'd rather just force it to use a consistent sed, whether that's bsdsed or gnused. Your kernel is not a reliable predictor for your sed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants