Skip to content

feat(nifi): Add git-sync #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025
Merged

feat(nifi): Add git-sync #1107

merged 2 commits into from
May 16, 2025

Conversation

siegfriedweber
Copy link
Member

Description

Add git-sync to the Nifi image

Definition of Done Checklist

Note

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.

Please make sure all these things are done and tick the boxes

  • Changes are OpenShift compatible
  • All added packages (via microdnf or otherwise) have a comment on why they are added
  • Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
  • All packages should have (if available) signatures/hashes verified
  • Add an entry to the CHANGELOG.md file
  • Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@siegfriedweber siegfriedweber self-assigned this May 7, 2025
@siegfriedweber siegfriedweber marked this pull request as ready for review May 8, 2025 14:51
@siegfriedweber siegfriedweber requested a review from a team May 8, 2025 14:51
@siegfriedweber siegfriedweber moved this to Development: Waiting for Review in Stackable Engineering May 8, 2025
sbernauer
sbernauer previously approved these changes May 9, 2025
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering May 9, 2025
@sbernauer sbernauer added this pull request to the merge queue May 16, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering May 16, 2025
Merged via the queue into main with commit 6567adc May 16, 2025
3 checks passed
@sbernauer sbernauer deleted the feat/nifi-git-sync branch May 16, 2025 10:49
@NickLarsenNZ
Copy link
Member

NickLarsenNZ commented May 16, 2025

Does this need a release note?
I'll add the label, but feel free to remove if you think it isn't needed.

@NickLarsenNZ NickLarsenNZ added scheduled-for/25.7.0 release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 16, 2025
@siegfriedweber
Copy link
Member Author

siegfriedweber commented May 16, 2025

Does this need a release note? I'll add the label, but feel free to remove if you think it isn't needed.

The release note will be added to the overarching ticket stackabletech/nifi-operator#739.

I moved the labels there.

@siegfriedweber siegfriedweber removed release-note Denotes a PR that will be considered when it comes time to generate release notes. scheduled-for/25.7.0 labels May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Development: Done
Development

Successfully merging this pull request may close these issues.

3 participants