Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doctrine dbal: support statements without args #245

Merged
merged 3 commits into from
Feb 4, 2022
+408 −16
Merged

doctrine dbal: support statements without args #245

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b7e2ad7
doctrine dbal: added failling tests for statements without args
clxmstaab Feb 4, 2022
a222b0c
fix
clxmstaab Feb 4, 2022
1f89eab
replay
clxmstaab Feb 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doctrine dbal: added failling tests for statements without args
@clxmstaab
clxmstaab committed Feb 4, 2022
commit b7e2ad798b49c838396ed2559b2913ccdbba5132
47 changes: 47 additions & 0 deletions tests/default/data/doctrine-dbal.php
View file
Original file line number Diff line number Diff line change
@@ -58,6 +58,9 @@ public function executeQuery(Connection $conn, array $types, QueryCacheProfile $

$stmt = $conn->executeCacheQuery('SELECT email, adaid, gesperrt, freigabe1u1 FROM ada WHERE adaid = ?', [1], $types, $qcp);
assertType('Doctrine\DBAL\Result<array{email: string, 0: string, adaid: int<0, 4294967295>, 1: int<0, 4294967295>, gesperrt: int<-128, 127>, 2: int<-128, 127>, freigabe1u1: int<-128, 127>, 3: int<-128, 127>}>', $stmt);

$stmt = $conn->executeQuery('SELECT email, adaid, gesperrt, freigabe1u1 FROM ada');
assertType('Doctrine\DBAL\Result<array{email: string, 0: string, adaid: int<0, 4294967295>, 1: int<0, 4294967295>, gesperrt: int<-128, 127>, 2: int<-128, 127>, freigabe1u1: int<-128, 127>, 3: int<-128, 127>}>', $stmt);
}

public function executeStatement(Connection $conn, int $adaid)
@@ -79,76 +82,120 @@ public function fetchAssociative(Connection $conn)
$query = 'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada WHERE adaid = ?';
$fetchResult = $conn->fetchAssociative($query, [1]);
assertType('array{email: string, adaid: int<0, 4294967295>, gesperrt: int<-128, 127>, freigabe1u1: int<-128, 127>}|false', $fetchResult);

$query = 'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada';
$fetchResult = $conn->fetchAssociative($query);
assertType('array{email: string, adaid: int<0, 4294967295>, gesperrt: int<-128, 127>, freigabe1u1: int<-128, 127>}|false', $fetchResult);
}

public function fetchNumeric(Connection $conn)
{
$query = 'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada WHERE adaid = ?';
$fetchResult = $conn->fetchNumeric($query, [1]);
assertType('array{string, int<0, 4294967295>, int<-128, 127>, int<-128, 127>}|false', $fetchResult);

$query = 'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada';
$fetchResult = $conn->fetchNumeric($query);
assertType('array{string, int<0, 4294967295>, int<-128, 127>, int<-128, 127>}|false', $fetchResult);
}

public function iterateAssociative(Connection $conn)
{
$query = 'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada WHERE adaid = ?';
$fetchResult = $conn->iterateAssociative($query, [1]);
assertType('Traversable<int, array{email: string, adaid: int<0, 4294967295>, gesperrt: int<-128, 127>, freigabe1u1: int<-128, 127>}>', $fetchResult);

$query = 'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada';
$fetchResult = $conn->iterateAssociative($query);
assertType('Traversable<int, array{email: string, adaid: int<0, 4294967295>, gesperrt: int<-128, 127>, freigabe1u1: int<-128, 127>}>', $fetchResult);
}

public function iterateNumeric(Connection $conn)
{
$query = 'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada WHERE adaid = ?';
$fetchResult = $conn->iterateNumeric($query, [1]);
assertType('Traversable<int, array{string, int<0, 4294967295>, int<-128, 127>, int<-128, 127>}>', $fetchResult);

$query = 'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada';
$fetchResult = $conn->iterateNumeric($query);
assertType('Traversable<int, array{string, int<0, 4294967295>, int<-128, 127>, int<-128, 127>}>', $fetchResult);
}

public function iterateColumn(Connection $conn)
{
$query = 'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada WHERE adaid = ?';
$fetchResult = $conn->iterateColumn($query, [1]);
assertType('Traversable<int, string>', $fetchResult);

$query = 'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada';
$fetchResult = $conn->iterateColumn($query);
assertType('Traversable<int, string>', $fetchResult);
}

public function iterateKeyValue(Connection $conn)
{
$query = 'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada WHERE adaid = ?';
$fetchResult = $conn->iterateKeyValue($query, [1]);
assertType('Traversable<string, int<0, 4294967295>>', $fetchResult);

$query = 'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada';
$fetchResult = $conn->iterateKeyValue($query);
assertType('Traversable<string, int<0, 4294967295>>', $fetchResult);
}

public function fetchOne(Connection $conn)
{
$query = 'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada WHERE adaid = ?';
$fetchResult = $conn->fetchOne($query, [1]);
assertType('string|false', $fetchResult);

$query = 'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada';
$fetchResult = $conn->fetchOne($query);
assertType('string|false', $fetchResult);
}

public function fetchFirstColumn(Connection $conn)
{
$query = 'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada WHERE adaid = ?';
$fetchResult = $conn->fetchFirstColumn($query, [1]);
assertType('array<int<0, max>, string>', $fetchResult);

$query = 'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada';
$fetchResult = $conn->fetchFirstColumn($query);
assertType('array<int<0, max>, string>', $fetchResult);
}

public function fetchAllNumeric(Connection $conn)
{
$query = 'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada WHERE adaid = ?';
$fetchResult = $conn->fetchAllNumeric($query, [1]);
assertType('array<int<0, max>, array{string, int<0, 4294967295>, int<-128, 127>, int<-128, 127>}>', $fetchResult);

$query = 'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada';
$fetchResult = $conn->fetchAllNumeric($query);
assertType('array<int<0, max>, array{string, int<0, 4294967295>, int<-128, 127>, int<-128, 127>}>', $fetchResult);
}

public function fetchAllAssociative(Connection $conn)
{
$query = 'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada WHERE adaid = ?';
$fetchResult = $conn->fetchAllAssociative($query, [1]);
assertType('array<int<0, max>, array{email: string, adaid: int<0, 4294967295>, gesperrt: int<-128, 127>, freigabe1u1: int<-128, 127>}>', $fetchResult);

$query = 'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada';
$fetchResult = $conn->fetchAllAssociative($query);
assertType('array<int<0, max>, array{email: string, adaid: int<0, 4294967295>, gesperrt: int<-128, 127>, freigabe1u1: int<-128, 127>}>', $fetchResult);
}

public function fetchAllKeyValue(Connection $conn)
{
$query = 'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada WHERE adaid = ?';
$fetchResult = $conn->fetchAllKeyValue($query, [1]);
assertType('array<string, int<0, 4294967295>>', $fetchResult);

$query = 'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada';
$fetchResult = $conn->fetchAllKeyValue($query);
assertType('array<string, int<0, 4294967295>>', $fetchResult);
}

public function fetchStringable(Connection $conn)