Add ObjectMultimapCmp functor to sort ObjectMap entries numerically when possible #1492
+43
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
AT: WIP
|
CLANG-FORMAT TEST - PASSED |
Contributor
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
leekillough
force-pushed
the
ObjectMultimapCmp
branch
from
894623a to
68c1063
Compare
github-actions
bot
added
AT: WIP
|
CLANG-FORMAT TEST - PASSED |
Contributor
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
Contributor
Author
|
This is also causing benchmark test failures which need to be resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ObjectMultimapCmpfunctor to sortObjectMapentries numerically when possibleThis sorts
ObjectMapkeys numerically when possible, falling back to lexicographic comparison if the keys are not numeric.Add
ObjectMultimapas the type of the{name, ObjectMap *}map sorted according toObjectMultimapCmp.It also makes
EmptyVarsa static local variable in a function, to get around the static initialization order fiasco.