Document more #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lu-zero
force-pushed
the
ssmendon-pratt-pr
branch
from
6cad15e to
895e646
Compare
ssmendon
force-pushed
the
ssmendon-pratt-pr
branch
from
8e95be1 to
17a688d
Compare
Owner
|
Thanks for this! I'm going to refactor some of the existing documentation based on my ideas in winnow-rs#804 (comment), so I'll review this later. |
Author
|
I should have some time in the coming days if you need an hand polishing the set. |
lu-zero
force-pushed
the
ssmendon-pratt-pr
branch
from
fac76c1 to
0c6de56
Compare
Author
|
Had time to rebase and it still applies cleanly luckily :) |
ssmendon
force-pushed
the
ssmendon-pratt-pr
branch
from
17a688d to
961694e
Compare
ssmendon
force-pushed
the
ssmendon-pratt-pr
branch
from
961694e to
0c6de56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we could even keep the structs opaque.