Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issue caused by upstream changes to pybind11_protobuf #26

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

srmainwaring
Copy link
Owner

@srmainwaring srmainwaring commented Apr 30, 2024

Upstream changes to pybind11_protobuf have caused this project to not build (see #23 and #24). This PR fixes the build and brings the library into alignment with changes in Gazebo Harmonic that add Python bindings to gz-msgs and gz-transport.

Ubuntu build issues

$ protoc --version
libprotoc 3.12.4

- Support Garden and Harmonic (default).
- Move extension modules into namespace gz.python to avoid conflicts.
- Rename module extras to msgs_extras.
- Remove Python binding generation - instead use bindings in gz-msgs.

Signed-off-by: Rhys Mainwaring <[email protected]>
Signed-off-by: Rhys Mainwaring <[email protected]>
@srmainwaring srmainwaring added the bug Something isn't working label Apr 30, 2024
@srmainwaring srmainwaring self-assigned this Apr 30, 2024
Signed-off-by: Rhys Mainwaring <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant