Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove footnotes from og:description #529

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Remove footnotes from og:description #529

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ad0d0ff
description: remove footnotes
TristanCacqueray Mar 15, 2024
d2e8fd9
Merge branch 'master' into desc-foot
srid Mar 15, 2024
36a68af
Update emanote.cabal
srid Mar 15, 2024
b23551a
Update CHANGELOG.md
srid Mar 15, 2024
47fc8b9
Update heist-extra to handle footnote removal from description
TristanCacqueray Mar 15, 2024
2edffed
Use correct flake input
srid Mar 18, 2024
4b8c274
Merge branch 'master' into desc-foot
srid Mar 18, 2024
360ce06
docs: re-arrange to test footnote behaviour
srid Mar 18, 2024
2b45e8b
Merge branch 'master' into desc-foot
srid Mar 25, 2024
4a6c2a3
nix: Update commonmark-wikilink
srid Mar 25, 2024
6eef231
Merge branch 'master' into desc-foot
srid Jul 2, 2024
e12d09e
Merge branch 'master' into desc-foot
srid Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions emanote/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
- Enable auto identifier for org files ([\#502](https://github.com/srid/emanote/pull/502))
- Bug fixes:
- Emanote no longer crashes when run on an empty directory ([\#487](https://github.com/srid/emanote/issues/487))
- Remove footnotes from `og:description` ([\#529](https://github.com/srid/emanote/pull/529))
- Stork search fixes
- Fix empty stork index generation when using more than 1 layer ([\#493](https://github.com/srid/emanote/issues/493))
- Stork search index is now uses note path from their associated layer ([\#495](https://github.com/srid/emanote/pull/495))
Expand Down
2 changes: 1 addition & 1 deletion emanote/emanote.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
cabal-version: 2.4
name: emanote
version: 1.3.16.0
version: 1.3.17.0
license: AGPL-3.0-only
copyright: 2022 Sridhar Ratnakumar
maintainer: [email protected]
Expand Down
8 changes: 7 additions & 1 deletion emanote/src/Emanote/Model/Note.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ applyNoteMetaFilters doc =
)
addDescriptionFromBody =
overrideAesonText ("page" :| ["description"]) $ \case
B.Para is -> [WL.plainify is]
B.Para is -> [WL.plainify (mapMaybe removeInlineNotes is)]
_ -> mempty
-- FIXME this doesn't take splice rendering into account. Specifically,
-- `![[foo.jpeg]]` is not handled at all.
Expand All @@ -406,4 +406,10 @@ applyNoteMetaFilters doc =
pure $ SData.oneAesonText (toList key) val
)

-- TODO: apply this recursively
TristanCacqueray marked this conversation as resolved.
Show resolved Hide resolved
removeInlineNotes :: B.Inline -> Maybe B.Inline
removeInlineNotes = \case
B.Note{} -> Nothing
a -> Just a

makeLenses ''Note
Loading