Parse trailers even when an error occurs #3365
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedre
commented
Aug 21, 2025
| exception = response.grpcResponseToException() | ||
| } catch (e: IOException) { | ||
| exception = response.grpcResponseToException(e) | ||
| exception = response.grpcResponseToException(false, e) |
Author
There was a problem hiding this comment.
intentionally only did this for unary calls because there's a specific test to disallow this for streaming (duplexSuspend_responseBodyThrows) - i suspect this is because when something goes wrong, the channel is explicitly closed, therefore making it not possible to read the trailers.
squarejesse
reviewed
Aug 22, 2025
squarejesse
left a comment
squarejesse
left a comment
There was a problem hiding this comment.
I think if we want to do this, we should detect an empty gRPC response, and not throw an exception in that case before we read the trailers
ahmedre
force-pushed
the
read_trailers_on_error
branch
from
f86e697 to
1daf6d2
Compare
Author
thanks - done. |
It is possible for gRPC error responses to be empty and for servers to send the error information within trailers without also sending them in headers. In these cases, Wire will propagate an exception due to no response body and will not attempt to read trailers, relying only on headers instead. This patch allows Wire to attempt to parse the trailers for non-streaming requests instead of only relying on headers.
ahmedre
force-pushed
the
read_trailers_on_error
branch
from
1daf6d2 to
3541dc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for gRPC error responses to be empty and for servers to send the error information within trailers without also sending them in headers. In these cases, Wire will propagate an exception due to no response body and will not attempt to read trailers, relying only on headers instead.
This patch allows Wire to attempt to parse the trailers for non-streaming requests instead of only relying on headers.