Merged
Conversation
Contributor
Author
|
@JakeWharton Please review |
JakeWharton
approved these changes
Apr 7, 2025
swankjesse
reviewed
May 27, 2025
|
|
||
| /** Returns the Content-Length as reported by the response headers. */ | ||
| internal fun Response.headersContentLength(): Long = headers["Content-Length"]?.toLongOrDefault(-1L) ?: -1L | ||
| internal fun Response.headersContentLength(): Long = headers["Content-Length"]?.toLongOrNull() ?: -1L |
Collaborator
There was a problem hiding this comment.
Why make our code slower?
Here’s the Java equivalent of what we had before (IntelliJ ‘Show Kotlin Bytecode’, followed by ‘Decompile’):
public static final long headersContentLength(@NotNull Response $this$headersContentLength) {
Intrinsics.checkNotNullParameter($this$headersContentLength, "<this>");
String var10000 = $this$headersContentLength.headers().get("Content-Length");
return var10000 != null ? _UtilCommonKt.toLongOrDefault(var10000, -1L) : -1L;
}and here’s after:
public static final long headersContentLength(@NotNull Response $this$headersContentLength) {
Intrinsics.checkNotNullParameter($this$headersContentLength, "<this>");
String var10000 = $this$headersContentLength.headers().get("Content-Length");
long var2;
if (var10000 != null) {
Long var1 = StringsKt.toLongOrNull(var10000);
if (var1 != null) {
var2 = var1;
return var2;
}
}
var2 = -1L;
return var2;
}The old code didn’t allocate, and the new code does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #8721