Skip to content

Reopen addImport with backward compatible addImports#1380

Open
InsanusMokrassar wants to merge 2 commits intosquare:mainfrom
InsanusMokrassar:patch-1
Open

Reopen addImport with backward compatible addImports#1380
InsanusMokrassar wants to merge 2 commits intosquare:mainfrom
InsanusMokrassar:patch-1

Conversation

@InsanusMokrassar
Copy link
Copy Markdown

@InsanusMokrassar InsanusMokrassar commented Oct 6, 2022

Add API that require to use at least one name in imports in case of variadic syntax usage. The old behaviour have thrown an exception in runtime, but that one will not allow to use variadic syntax without at least one name

@Egorand
Copy link
Copy Markdown
Collaborator

Egorand commented Oct 7, 2022

Can you please explain what the motivation for this change is?

@InsanusMokrassar
Copy link
Copy Markdown
Author

@Egorand you may look at this PR conversation for more info

@Egorand
Copy link
Copy Markdown
Collaborator

Egorand commented Oct 7, 2022

Not convinced that these changes are backwards compatible, CI should catch it - let's wait for the results. Also, can you please provide a more descriptive PR title that explains what the change does and why?

@Egorand
Copy link
Copy Markdown
Collaborator

Egorand commented Oct 22, 2022

Hey @InsanusMokrassar, looks like the code doesn't compile - would you be able to fix it?

@InsanusMokrassar
Copy link
Copy Markdown
Author

Of course. Sorry for the delay, usually I am very busy, but I plan to fix it as soon as possible. Thanks for waiting :)

@Egorand
Copy link
Copy Markdown
Collaborator

Egorand commented Oct 24, 2022

Thanks & no pressure - just wanted to check if you're still planning to update the PR!

@Egorand Egorand changed the base branch from master to main July 5, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants