PR: CI: Add workflow to run tests with PyQt6/PySide6 #23118
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rear1019
commented
Nov 29, 2024
| push: | ||
| branches: | ||
| - master | ||
| - qt6_ci # for testing only |
There was a problem hiding this comment.
Using a cron-based trigger is probably more sensible for now?
The qt6_ci is for testing only and will be removed
Comment on lines
+152
to
+155
| # .github/scripts/run_tests.sh || \ | ||
| # .github/scripts/run_tests.sh || \ | ||
| # .github/scripts/run_tests.sh || \ | ||
| .github/scripts/run_tests.sh |
There was a problem hiding this comment.
Commented out for faster testing.
Comment on lines
+141
to
+142
| # env: | ||
| # GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
For testing only, will be re-added
| - name: Run tests | ||
| shell: bash -l {0} | ||
| env: | ||
| # GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
For testing only, will be re-added
3 tasks
For now the tests run on Linux only. Only pip-based installation is used as conda has no PyQt6 package yet. The workflow file based on the existing one for Linux.
Fix 'extras_require' in setup.py to fix the warning. This requires fixes for the parsing of dependencies in test_dependencies_in_sync.py: Use the 'packaging' module which simplifies the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This is a draft to add PyQt6/PySide6 to the CI as suggested in PR #22620:
Issue(s) Resolved
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct:
rear1019