Use ConnectionCustomizer to ensure login is only done when needed - #4
Merged
Conversation
Contributor
Author
|
@sbihel any chance you could give this PR a review? |
sbihel
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves the problem of the multiple Login calls. There does not seem a way to force a specific
ConnectionCustomizeron the pool, but I guess users will find out soon enough if their login does not work.Note that the TODO comment was slightly incorrect. When a
Sessionis dropped, cryptoki does not do aLogout, but it simply does aCloseSession. When all sessions are closed, you need to login again.I did some extensive testing with our Utimaco CryptoServer library. It seems to work, even when reconnecting in the library.