Do not validate ignoredRequests from WebSecurity.ignoring() #17158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Closes spring-projectsgh-17155 Signed-off-by: DingHao <[email protected]>
|
Hi, @kse-music, I'm not sure that we want to make an exception for the web-ignoring configuration. If such a configuration were released into production, there would be no security and no one would get notified. It appears to me that the error message in #17155 is correct; I think it's a matter of finding a better way to turn off security during development. I'm going to close this PR for now while discussion continues in the ticket. We can always reopen it if this route is revisited. |
jzheaux
added
in: web
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-17155