Remove ConsumerRebalanceProtocolTests #3936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests were just verifying Kafka’s own rebalance protocol, not anything specific in Spring for Apache Kafka framework. Since the new protocol is handled entirely by the Kafka server, there’s no need to test it here. Users can enable the protocol via the config - group.protocol. No extra framework logic involved. Testing the protocol in the framework test suite is unnecessary and leads to long-running tests without added value. See the ref docs here: https://docs.spring.io/spring-kafka/reference/4.0/kafka/receiving-messages/rebalance-listeners.html#new-rebalalcne-protocol Signed-off-by: Soby Chacko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests were just verifying Kafka’s own rebalance protocol, not anything specific in Spring for Apache Kafka framework. Since the new protocol is handled entirely by the Kafka server, there’s no need to test it here. Users can enable the protocol via the config - group.protocol. No extra framework logic involved.
Testing the protocol in the framework test suite is unnecessary and leads to long-running tests without added value.
See the ref docs here:
https://docs.spring.io/spring-kafka/reference/4.0/kafka/receiving-messages/rebalance-listeners.html#new-rebalalcne-protocol