Apply Nullability to spring-integration-jpa
#10157
Merged
+87
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related to: spring-projects#10083 Signed-off-by: Jiandong Ma <[email protected]>
artembilan
requested changes
Jun 23, 2025
...rc/main/java/org/springframework/integration/jpa/outbound/JpaOutboundGatewayFactoryBean.java
Outdated
Show resolved
Hide resolved
spring-integration-jpa/src/main/java/org/springframework/integration/jpa/core/JpaExecutor.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jiandong Ma <[email protected]>
Signed-off-by: Jiandong Ma <[email protected]>
mjd507
commented
Jun 23, 2025
| @@ -398,10 +404,7 @@ public void afterPropertiesSet() { | |||
| else if (this.flush) { | |||
| this.flushSize = 1; | |||
| } | |||
|
|
|||
| if (this.evaluationContext == null) { | |||
There was a problem hiding this comment.
is it harmful to remove in this version?
There was a problem hiding this comment.
I don't think so.
This is major version, so we can have some breaking changes.
But I don't see how this one could be.
There was a problem hiding this comment.
okay, so instead of depredated method setIntegrationEvaluationContext(), can we simply remove that method?
There was a problem hiding this comment.
No. We never remove a public API in our classes just because.
Has to be deprecated first.
artembilan
requested changes
Jun 23, 2025
spring-integration-jpa/src/main/java/org/springframework/integration/jpa/core/JpaExecutor.java
Outdated
Show resolved
Hide resolved
| @@ -398,10 +404,7 @@ public void afterPropertiesSet() { | |||
| else if (this.flush) { | |||
| this.flushSize = 1; | |||
| } | |||
|
|
|||
| if (this.evaluationContext == null) { | |||
There was a problem hiding this comment.
I don't think so.
This is major version, so we can have some breaking changes.
But I don't see how this one could be.
spring-integration-jpa/src/main/java/org/springframework/integration/jpa/core/JpaExecutor.java
Show resolved
Hide resolved
Signed-off-by: Jiandong Ma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to: #10083