Fix #34760: ignore Kotlin DefaultConstructorMarker in BeanUtils#getParameterNames #34860
+69
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue#34760
Description
When a Kotlin value class is used as a constructor parameter, the compiler generates an extra synthetic parameter of type
kotlin.jvm.internal.DefaultConstructorMarker
.When this step is executed:
It will call
KotlinReflectionParameterNameDiscoverer#getParameterNames(List<KParameter>)
, whereReflectJvmMapping#getKotlinFunction
is called to convert a constructor into a function.DefaultConstructorMarker
will be dropped after the conversion. This then causes a mismatch between the number of parameter names discovered and the actual constructor parameter count inBeanUtils#getParameterNames
:Since
DefaultConstructorMarker
exists solely to prevent signature clashes, it is safe to exclude it from the parameter count. Similar thought as in: Ignore binding Kotlin synthetic default constructorsProposed Change
Replace the existing assertion with:
Tests
Added new cases to
BeanUtilsKotlinTests
to testBeanUtils#getParameterNames
.